via job cycles cause infinite recursion in get_or_create_category_node()

[Po-Hsu Lin]

Step to reproduce this:

$ bzr branch lp:checkbox -r 3661
run checkbox-cli in venv
$ ./mkvenv /tmp/working
$ . /tmp/working/bin/active
$ checkbox-cli
Select the 'client-cert' whitelist to start.

The resource job section will complain about:
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing

And it will crash with
  File "/home/ubuntu/src/tmp/checkbox/plainbox/plainbox/impl/job.py", line 224, in get_or_create_category_node
    category_node = self.create_category_node(category_job)
  File "/home/ubuntu/src/tmp/checkbox/plainbox/plainbox/impl/job.py", line 250, in create_category_node
    if category_job.summary == category_job.partial_id:
  File "/home/ubuntu/src/tmp/checkbox/plainbox/plainbox/impl/unit/job.py", line 260, in summary
    return self.get_record_value('summary', self.partial_id)
  File "/home/ubuntu/src/tmp/checkbox/plainbox/plainbox/impl/unit/job.py", line 252, in partial_id
    return self.get_record_value('id', self.get_record_value('name'))
  File "/home/ubuntu/src/tmp/checkbox/plainbox/plainbox/impl/unit/unit.py", line 593, in get_record_value
    if value is not None and self.is_parametric:
RuntimeError: maximum recursion depth exceeded

Please refer to the attachment for the full error log.

[Po-Hsu Lin (cypressyew)]

I do a bisect for this, it looks like it happened on revision 3661,
here is the MR http://bazaar.launchpad.net/~checkbox-dev/checkbox/trunk/revision/3661

[Zygmunt Krynicki (zyga)]

13:23 <@zyga> hah
13:23 <@zyga> I get it
13:23 <@zyga> __resource__ is its own via job :)