only pass stack id to init stacklock is enough

Bug #1441972 reported by Ethan Lynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Ethan Lynn

Bug Description

For most of time, stack id is enough for class stacklock, only acquire() function need other information of stack.
It's better to lazy load stack when necessary.

https://github.com/openstack/heat/blob/b4a0ee8bafad55cbc59498a4a43383ed26ef6713/heat/engine/stack_lock.py#L88-L89

Ethan Lynn (ethanlynn)
Changed in heat:
assignee: nobody → Ethan Lynn (ethanlynn)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171930

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/171930
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0b59af6acc0ce8cc664b5977835ecafe23c4f5f1
Submitter: Jenkins
Branch: master

commit 0b59af6acc0ce8cc664b5977835ecafe23c4f5f1
Author: Ethan Lynn <email address hidden>
Date: Thu Apr 9 13:25:19 2015 +0800

    Pass stack id to init stacklock

    Only acquire() function in stacklock needs to load whole stack,
    other function only needs stack id. This patch only pass
    stack id for stacklock so that in some place we don't need
    to load whole stack.

    Change-Id: Iaad5f4a871f925c4052d159a5d95184681d5bd28
    Closes-Bug: #1441972

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.