_create_subnet_from_implicit_pool assumes external network

[Aaron Rosen]

2015-04-08 11:28:07.968 ERROR neutron.api.v2.resource [req-61265bfc-9503-452d-80e2-022c449feee0 admin f4c311581f4d4d138d87012d00ae3b24] create failed
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource Traceback (most recent call last):
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/api/v2/resource.py", line 83, in resource
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource result = method(request=request, **args)
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/api/v2/base.py", line 461, in create
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource obj = obj_creator(request.context, **kwargs)
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/db/db_base_plugin_v2.py", line 1348, in create_subnet
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource return self._create_subnet_from_implicit_pool(context, subnet)
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/db/db_base_plugin_v2.py", line 1285, in _create_subnet_from_implicit_pool
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource if network.external:
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource AttributeError: 'Network' object has no attribute 'external'
2015-04-08 11:28:07.968 TRACE neutron.api.v2.resource

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/171770

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/171770
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bde4f6f767d3da4c3eca15390ea45a934f2ff398
Submitter: Jenkins
Branch: master

commit bde4f6f767d3da4c3eca15390ea45a934f2ff398
Author: Aaron Rosen <email address hidden>
Date: Mon Apr 20 12:45:12 2015 -0700

    _create_subnet_from_implicit_pool assumes external network extension

    network.external is only present if one is using the external_net_db
    mixin. This patch just adds a check to see network has the attribute
    external to avoid an Attribute error.

    Closes-bug: 1441793
    Change-Id: Ic003879b557a8c7ab52268a95d08d6d710618438

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072