Simplify and modernize model_query()

[Henry Gessau]

From zzzeek on IRC, 2015-04-08:

this thing: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L486

this is in a few places. the model_query() for neutron is broken up into these three awkward phases, and seveal of these pliugins put an unnecessary and expensive OUTER JOIN on all queries

this should be an INNER JOIN and only when the filter_hook is actually in use

now its hard for me to change this b.c. everyone will be like, it works great and nobody uses that thing so who cares
but i really want to fix up how we build queries to be cleaner, using newer techniques

there’s a quick cahnge we can make right there that will probably corect the outerjoin, we can do query.join() right in the _ml2_port_result_filter_hook for now

[Armando Migliaccio (armando-migliaccio)]

This bug is > 240 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]