iscsi_ilo driver : deploy fails with ipa ramdisk if user image do not have boot iso property in UEFI boot mode

[Shivanand Tendulker]

1. Configure iscsi_ilo driver to use IPA ramdisk
2. Create a user partition cloud image (Ubuntu) using DIB
3. Upload cloud image into glance without corresponding boot_iso property
4. Initiate deploy in UEFI boot mode
5. Ironic claims deploy success by moving the node into 'active' state, but the reboot of the node using auto generated boot iso hangs in grub menu as it does not find the kernel, ramdisk to boot .

Root Cause:
--------------
Autogenerated boot iso for iscsi_ilo driver fails when Fedora based IPA ramdisk is used for deploy in UEFI boot mode. The keywords used (linux and initrd) in grub.cfg template are specific to Ubuntu only. They are not recognized by Fedora.
Have changed it to keywords (linuxefi and initrdefi) which are recognized by both Ubuntu and Fedora deploy ramdisks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/172313

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172313
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=f7a57c982726041092e6496eb68c90b37e8620a8
Submitter: Jenkins
Branch: master

commit f7a57c982726041092e6496eb68c90b37e8620a8
Author: Shivanand Tendulker <email address hidden>
Date: Thu Apr 9 01:30:57 2015 -0700

    Fix for automated boot iso issue with IPA ramdisk

    Autogenerated boot iso for iscsi_ilo driver fails when
    Fedora based IPA ramdisk is used for deploy in UEFI boot mode.
    The keywords used (linux and initrd) in grub.cfg template are
    specific to Ubuntu only. They are not recognized by Fedora.
    Have changed it to keywords (linuxefi and initrdefi) which are
    recognized by both Ubuntu and Fedora deploy ramdisks.

    Also the menuentry name has been changed to 'boot_partition' in
    grub config file. This is done to make it consistent with pxe
    driver's elilo config file wherein menuentry name for the final
    boot of user image is 'boot_partition'.

    Closes-Bug: 1441691

    Change-Id: Ia6fdbf4868e6606a18b33ce2b75f29f701a31b35