Container ACL not handling NotFound properly

Bug #1441555 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Medium
Thomas Herve

Bug Description

Since 237f7674cc73c6688f3ea00511675ce1da2bf4e1, trying to retrieve a non-existing container gives a 403 instead of a 404. It has been highlighted by client build failures.

I believe the behavior can be easily fixed by mirroring what's been done for secrets (ie, not create the controller when the order doesn't exist).

Thomas Herve (therve)
Changed in barbican:
assignee: nobody → Thomas Herve (therve)
Changed in barbican:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/171553
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=21efb841b052442f2bc4c8382c4e0088feeab6ae
Submitter: Jenkins
Branch: master

commit 21efb841b052442f2bc4c8382c4e0088feeab6ae
Author: Thomas Herve <email address hidden>
Date: Wed Apr 8 12:01:22 2015 +0200

    Return container not found before ACL checks

    This fixes a recent regression where one user would get a 403 when
    trying to retrieve a unknown container, instead of a 404.

    Change-Id: I59c6b806591ca4c943615c3b528752ef8ba1e0dd
    Closes-Bug: #1441555

Changed in barbican:
status: In Progress → Fix Committed
Changed in barbican:
milestone: none → kilo-rc1
Changed in barbican:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in barbican:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.