python-troveclient

tes___eq__ is not called

Bug #1441518 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-troveclient
Fix Released
Undecided
Sushil Kumar
python-troveclient 1.2.0 "1.2.0"

Bug Description

tes___eq__ in https://github.com/openstack/python-troveclient/blob/master/troveclient/tests/test_base.py#L493:L514 is not run.

Since the name is not prefixed with test, it is not running.

Also it looks that this test is not correctly implemented, because it uses an assert assertNotTrue which is wrong.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171530

Changed in python-troveclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-troveclient (master)

Reviewed: https://review.openstack.org/171530
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=5125628c2875b8d8295530eb428f7dfa26884cd1
Submitter: Jenkins
Branch: master

commit 5125628c2875b8d8295530eb428f7dfa26884cd1
Author: Sushil Kumar <email address hidden>
Date: Wed Apr 8 09:06:28 2015 +0000

    Fixes unit-test in troveclient

    1. Renames tes___eq__ to be test___eq__,
       because earlier method was not being called.
    2. Corrects the test-code in test___eq__,
       for the failures it gave when it started running.
    3. Removes some unused code from tests,
       there were few lines/methods which were not used by tests
       just removed/updated them.

    Change-Id: I90aa8cb9bb9f5d15697f00df0ba1defa0ef7be59
    Closes-Bug: #1441518

Changed in python-troveclient:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in python-troveclient:
milestone: none → 1.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.