crashes when load multi page visio and select page 2 or more

[Nithin]

Inkscape crashes when load multi page visio (vsd) file and select page other than 1, problem exists with version 0.91 (64 bit) and OS Windows 7.

[Alvin Penner (apenner)]

could you attach the .vsd file?

[su_v (suv-lp)]

Possibly the same underlying issue as reported earlier in
* Bug #1395435 “Inkscape crashes on load CDR select sheet”
  https://bugs.launchpad.net/inkscape/+bug/1395435
(AFAIK the page selector widgets are basically the same in import dialogs used for Visio and CorelDraw files)

[Nithin (nithinsrkdkl)]

I'll try to get a multipage visio file that i could provide you guys.

On Wed, Apr 8, 2015 at 5:10 PM, Alvin Penner <email address hidden> wrote:

> could you attach the .vsd file?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1441437
>
> Title:
> crashes when load multi page visio and select page 2 or more
>
> Status in Inkscape: Vector Graphics Editor:
> New
>
> Bug description:
> Inkscape crashes when load multi page visio (vsd) file and select page
> other than 1, problem exists with version 0.91 (64 bit) and OS Windows
> 7.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/inkscape/+bug/1441437/+subscriptions
>

--
Thanks,
Nithin

[Nithin (nithinsrkdkl)]

I'll try to get a multipage vsd that i could provide you.

On Wed, Apr 8, 2015 at 5:10 PM, Alvin Penner <email address hidden> wrote:

> could you attach the .vsd file?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1441437
>
> Title:
> crashes when load multi page visio and select page 2 or more
>
> Status in Inkscape: Vector Graphics Editor:
> New
>
> Bug description:
> Inkscape crashes when load multi page visio (vsd) file and select page
> other than 1, problem exists with version 0.91 (64 bit) and OS Windows
> 7.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/inkscape/+bug/1441437/+subscriptions
>

--
Thanks,
Nithin

[Alvin Penner (apenner)]

crash reproduced on Windows XP, Inkscape 0.91+devel r14031 (Mar 24 2015)

- load the attached file using File->Open
- in the preview window, click on Select Page and type in 2
- hit Enter, get crash, backtrace attached

(gdb) symbol-file inkscape.dbg
Reading symbols from C:\InkscapeBZR\inkscape/inkscape.dbg...done.
(gdb) run
Starting program: C:\InkscapeBZR\inkscape/inkscape.exe
[New thread 3892.0xe90]
[New thread 3892.0xf38]
[New thread 3892.0xf40]
[New thread 3892.0xe70]
[New thread 3892.0xe9c]
[New thread 3892.0xea8]
[New thread 3892.0xeac]
[New thread 3892.0xe68]
warning: Lowest section in C:\WINDOWS\system32\xpsp2res.dll is .rsrc at 00011000

warning: HEAP[inkscape.exe]:
warning: Invalid Address specified to RtlFreeHeap( 00030000, 09207808 )

Program received signal SIGTRAP, Trace/breakpoint trap.
0x7c90120f in ntdll!DbgUiConnectToDbg () from C:\WINDOWS\system32\ntdll.dll
(gdb) bt
#0 0x7c90120f in ntdll!DbgUiConnectToDbg ()
   from C:\WINDOWS\system32\ntdll.dll
#1 0x7c96e139 in ntdll!RtlpNtMakeTemporaryKey ()
   from C:\WINDOWS\system32\ntdll.dll
#2 0x7c96e576 in ntdll!RtlpNtMakeTemporaryKey ()
   from C:\WINDOWS\system32\ntdll.dll
#3 0x7c96f75e in ntdll!RtlpNtMakeTemporaryKey ()
   from C:\WINDOWS\system32\ntdll.dll
#4 0x7c94bc4c in ntdll!LdrFindEntryForAddress ()
   from C:\WINDOWS\system32\ntdll.dll
#5 0x00030000 in ?? ()
#6 0x50000061 in ?? ()
#7 0x09207808 in ?? ()
#8 0x00030000 in ?? ()
#9 0x09207808 in ?? ()
#10 0x40000060 in ?? ()
#11 0x0023cab4 in ?? ()
#12 0x03fde750 in ?? ()
#13 0x03fde750 in ?? ()
#14 0x00000000 in ?? ()
(gdb)

[su_v (suv-lp)]

On OS X 10.7.5, with Inkscape 0.91 and 0.91+devel r14057:

1) load the attached file using File->Open
2) in the preview window, click on Select Page and type in 2
3a) hit Enter
no crash, but the preview dialog closes and Inkscape fails to load the selected page
3b) hit Tab, click on 'Open'
3c) click on 'Open'
Inkscape opens the selected page as expected

Same as described in comment #4 of (private) bug #1240966, and also reproducible with the test case attached to bug #1395435 (CDR file).

AFAICT these three reports are all about the same issue (crash on Windows, failure to load on other platforms).

[Patrick Storz (ede123)]

Here's a patch that should fix most issues of bug #1395435 and bug #1441437 (I guess some issues might already have been fixed by the recent update of both devlibs and devlibs64 to include the latest librevenge based import filters):
- Loading preview images of pages works as intended
- Using enter key in input box does not cause the import to fail
- Clicking arrow up/down does not cause the spinner to increase/decrease by multiple pages*

* This was caused by the main thread being blocked with rendering the preview. The "mouse-up" event on the arrow button was therefore being delayed until rendering of the preview was completed. The artificially prolonged "mouse-down" on the arrow button then caused the widget to increase the page number more than expected.
I fiddled around with this a bit and tried to do the preview rendering in an idle callback of the main thread which sadly did not work (same symptoms). I resorted to using a timeout for now which is not satisfying but works well enough. To address this fully real multi-threading is probably required.

I tested this patch on Windows 7 x64 in both 32-bit builds and 64-bit builds of trunk revision 14691 as well as on Windows XP x86 and wasn't able to trigger any crashes. Please verify if possible.

[Patrick Storz (ede123)]

Committed in revision 14751.
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14751

The fix is based on the patch from comment #7.
The SpinButton issue should be properly fixed now (Rendering the preview is delayed until the mouse button is released)
I also simplified the dialog code a bit and made is resizeable so please check for regressions if possible (I tested on Windows 7 x64 with GTK2/3 builds)