'ironic port-create' 'node' vs 'node_uuid' is not backward compat

Bug #1441374 reported by Adam Gandelman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-ironicclient
Fix Released
High
aeva black

Bug Description

New client 0.5.0 was released. stable/juno jobs began pulling it in and discovered that port-create is not backward compatible with regards to node vs node_uuid:

2015-04-07 12:30:27.903 | ++ local node_id=753b06c1-4846-49f8-86dc-b878e9d070b0
2015-04-07 12:30:27.903 | ++ ironic port-create --address 52:54:00:81:3e:3e --node_uuid 753b06c1-4846-49f8-86dc-b878e9d070b0
2015-04-07 12:30:28.535 | usage: ironic port-create -a <address> -n <node> [-e <key=value>]
2015-04-07 12:30:28.536 | ironic port-create: error: argument -n/--node is required

It looks like https://review.openstack.org/#/c/155031/ hoped to make this work but the --node argument is marked as required.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171429

Changed in python-ironicclient:
assignee: nobody → Devananda van der Veen (devananda)
status: New → In Progress
aeva black (tenbrae)
Changed in python-ironicclient:
importance: Undecided → High
Changed in python-ironicclient:
assignee: Devananda van der Veen (devananda) → Ruby Loo (rloo)
Ruby Loo (rloo)
Changed in python-ironicclient:
assignee: Ruby Loo (rloo) → Devananda van der Veen (devananda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/171429
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=fe9a7b5628beec909c04447622859d3b0eb9fb52
Submitter: Jenkins
Branch: master

commit fe9a7b5628beec909c04447622859d3b0eb9fb52
Author: Devananda van der Veen <email address hidden>
Date: Tue Apr 7 16:10:55 2015 -0700

    Fix node_uuid option is required for port-create

    A previous commit separated the -n/--node option from the --node_uuid
    option on the "port-create" command. This meant that, even when the user
    specified --node_uuid, the client required -n/--node as well and would
    error out.

    This moves these options onto a single CLI argument.

    Change-Id: Idcc3217e07f9600f7db18182e9b1bc8b2ae356d3
    Closes-bug: #1441374

Changed in python-ironicclient:
status: In Progress → Fix Committed
Changed in python-ironicclient:
milestone: none → 0.7.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-ironicclient 0.5.1

This issue was fixed in the openstack/python-ironicclient 0.5.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.