bridges and default route is not restored after reboot

[Stanislav Makar]

OS: CentOS

Deploy cluster and reboot node

Before

route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
169.254.169.254 - 255.255.255.255 !H 0 - 0 -
10.20.0.0 0.0.0.0 255.255.255.0 U 0 0 0 br-fw-admin
172.16.0.0 0.0.0.0 255.255.255.0 U 0 0 0 br-ex
192.168.1.0 0.0.0.0 255.255.255.0 U 0 0 0 br-storage
192.168.0.0 0.0.0.0 255.255.255.0 U 0 0 0 br-mgmt
0.0.0.0 172.16.0.1 0.0.0.0 UG 0 0 0 br-ex

After
[root@node-13 ~]# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
169.254.169.254 - 255.255.255.255 !H 0 - 0 -
10.20.0.0 0.0.0.0 255.255.255.0 U 0 0 0 br-fw-admin
192.168.1.0 0.0.0.0 255.255.255.0 U 0 0 0 br-storage
172.16.0.0 0.0.0.0 255.255.255.0 U 0 0 0 br-ex
192.168.0.0 0.0.0.0 255.255.255.0 U 0 0 0 br-mgmt
0.0.0.0 10.20.0.2 0.0.0.0 UG 0 0 0 br-fw-admin

[Mike Scherbakov (mihgen)]

This is Critical, as user will get broken env after simple reboot of the cluster.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178566

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178566
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=56676453386e7e2d3e2882471b6b018b64e8c26d
Submitter: Jenkins
Branch: master

commit 56676453386e7e2d3e2882471b6b018b64e8c26d
Author: Stanislav Makar <email address hidden>
Date: Wed Apr 29 09:06:15 2015 +0000

    Fix correct default route restoring

    Change-Id: Id805f7fdc76e6f7384efa7509702026a3c13eb2b
    Closes-bug: #1441330

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179010

[Stanislav Makar (smakar)]

Above patch is really needed
previous patch does not fix this bug completely

[Stanislav Makar (smakar)]

custom ISO is here http://jenkins-product.srt.mirantis.net:8080/view/custom_iso/job/custom_6.1_iso/1147/

How to test:
1. Deploy any env on CentOS
2. After successful deployment go to any COMPUTE node
  - run "ip route show dev br-mgmt | grep default"
     should be displayed at least one record
      output should be like this "default via 192.168.0.7"
  - run "cat /etc/sysconfig/network | grep GATEWAY"
      should be nothing
  - run "grep TYPE -r /etc/sysconfig/network-scripts/ifcfg-eth*"
     there should be nothing
  - run "grep TYPE -r /etc/sysconfig/network-scripts/ifcfg-br*"
   there should be returned strings with TYPE=Bridge like below
   [root@node-4 ~]# grep TYPE -r /etc/sysconfig/network-scripts/ifcfg-br*
   /etc/sysconfig/network-scripts/ifcfg-br-fw-admin:TYPE=Bridge
   /etc/sysconfig/network-scripts/ifcfg-br-mgmt:TYPE=Bridge
   /etc/sysconfig/network-scripts/ifcfg-br-storage:TYPE=Bridge

3. reboot and and check if above the same
  If no - please notify me

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179010
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=c55c317da680ab35aaf11b4fb0886ee9512cbdf5
Submitter: Jenkins
Branch: master

commit c55c317da680ab35aaf11b4fb0886ee9512cbdf5
Author: Stanislav Makar <email address hidden>
Date: Thu Apr 30 09:57:05 2015 +0000

    Default route restoring and configuration

    * Remove default gateway from global network file
    * Add support of metric for default gateway
    * Fix interface type changing in cases if we call l3::ifconfig for bridge
    * Add and fix tests

    Change-Id: Ieb7526878a21ace03cc5fe76512a29be0ba23ba4
    Closes-bug: #1441330

[Bogdan Dobrelya (bogdando)]

related https://bugs.launchpad.net/fuel/+bug/1454712

[Przemyslaw Kaminski (pkaminski)]

Tested on ISO 432, CentOS with 1 controller, 1 compute: http://sprunge.us/FeUb