Wrong email ids passing validation during mass subscription

[Pavan Koli]

While using the mass subscription option to subscribe many email ids, email ids such as @gmail.com are passing through. The line responsible for validation of email ids(http://bazaar.launchpad.net/~mailman-coders/postorius/trunk/view/head:/src/postorius/views/list.py#L253) doesn't check if the len(parts[0])>0, hence email ids like @gmail.com are getting through.

One way to fix this would be to make the following change
if len(parts) != 2 or '.' not in parts[1] or len(parts[0])==0:

I've attached a patch, it takes help of django for email validation(I think this would be better than the earlier suggested way to validate email ids).

[Bhavesh Goyal (bhavesh-goyal093)]

While the patch would successfully reject addresses like @gmail.com but other invalid addresses such as '[e-mail]' , '...<email address hidden>' would still get accepted. To Ensure a perfectly valid address get accepted everytime, some regex matching needs to be done based on the format standards (like RFC - 5322) or better using Django validators which can save the cost of making a regular expression for an absolutely valid email

[Bhavesh Goyal (bhavesh-goyal093)]

A similar fix has been implemented in :

https://code.launchpad.net/~bhavesh-goyal093/postorius/fixed-invalid-email-acceptance