Cleaning up jasmine specs enclosure

Bug #1441299 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Thai Tran

Bug Description

Older spec files uses /* jshint globalstrict: true */ to declare that the file uses strict. Newer spec files encloses the entire javascript in a function and use the 'use strict' annotation. We should be using the newer format.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171321

Changed in horizon:
assignee: nobody → Thai Tran (tqtran)
status: New → In Progress
Changed in horizon:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/171321
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cc6f1ebf384de4660b19719ad980304ced8acde2
Submitter: Jenkins
Branch: master

commit cc6f1ebf384de4660b19719ad980304ced8acde2
Author: Thai Tran <email address hidden>
Date: Tue Apr 7 11:20:54 2015 -0700

    General specs enclosure cleanup

    Enclosed jasmine tests inside a function and removed the irrelevant
    globalstrict jshint comment.

    Change-Id: Idefbe2290e88bd3be62043e9601c1a909dc86620
    Closes-bug: #1441299

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/kilo)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/184865
Reason: We fixed the test failures with this:

https://review.openstack.org/#/c/185719/

Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.