Feature Request: Add new rate slider range options: 12% 16%
Bug #1441161 reported by
Owen Williams
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Wishlist
|
-MK- |
Bug Description
Because 10 is to little and 20 is too much! Also 12 and 16 are very common numbers on turntables.
This should be implemented by changing the mixxx config file to store the range * 100 instead of an opaque enum. That way users could actually have a range like 42 if they really wanted.
Backwards compatibility should be preserved by changing the name of the configuration option from RateRange to RateRangeDecimal. Old RateRange settings would be seamlessly upgraded to the new RateRangeDecimal setting.
Changed in mixxx: | |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
Changed in mixxx: | |
assignee: | nobody → Seemanta (seemanta) |
Changed in mixxx: | |
assignee: | Seemanta (seemanta) → nobody |
assignee: | nobody → -MK- (mk42) |
status: | Confirmed → In Progress |
milestone: | none → 2.1 |
Changed in mixxx: | |
status: | In Progress → Fix Committed |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I looked at the code. From the config file, the rate range is set to 2. This is an opaque enum type, right?
Can anyone point me in the code where this 2 is mapped to +/- 10% which I see in the deck slider for the rate change?
My understanding of this bug is as follows:
1. Add another entry in the config file called RateRangeDecimal and add support to parse this new key in the code in Dlgprefcontrols .cpp.
2. RateRangeDecimal can be any value between 0-100? So for 12, user will edit the file to 1200? For 16, the user will edit this to 1600? Am I right in my understanding?
3. We will still use RateRange for backwards compatibility and map this value to RateRangeDecimal. But if both are present, which will take precedence?
Thanks,
Seemanta