Move values for network_type to plugins.common.constants.py
Bug #1441043 reported by
Romil Gupta
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Low
|
Romil Gupta |
Bug Description
It is quite confusing to have values for network type in common.constants.py
instead of having in plugins.
Currently, the plugins/
like VLAN, VXLAN, GRE etc. but values for network type like ranges
are defined in common.constants.py which is not good, it is better to have
both things at the same place.
Also, it's better to move out few methods which are predominantly used in plugins
from common.utils.py to plugins.
Changed in neutron: | |
assignee: | nobody → Romil Gupta (romilg) |
status: | New → In Progress |
Changed in neutron: | |
milestone: | none → liberty-1 |
importance: | Undecided → Low |
Changed in neutron: | |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | liberty-1 → 7.0.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/166879 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=7f406805d93 298d0e65d340c2a 06ba0d2dd6ff76
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7f406805d93298d 0e65d340c2a06ba 0d2dd6ff76
Author: Romil Gupta <email address hidden>
Date: Mon Mar 23 08:05:41 2015 -0700
Move values for network_type to plugins. common. constants. py
It is quite confusing to have values for network type in common.constants.py common. constants. py.
instead of having in plugins.
Currently, the plugins/ common/ constants. py consists network_type constants
like VLAN, VXLAN, GRE etc. but values for network type like ranges
are defined in common.constants.py which is not good, it is better to have
both things at the same place.
This patch set addresses the same.
Moved out few methods which are predominantly used in plugins common. utils.py.
from common.utils.py to plugins.
Removed constants which were used in neutron-fwaas from common. constants. py: https:/ /review. openstack. org/#/c/ 168709/
plugins.
Closes-Bug: #1441043
Change-Id: Iecfb15c541ed5d 3cce95ba48f072a f7fa60ac6f1