Mirantis OpenStack

max_age quota usage refresh is not handled correctly

Bug #1440740 reported by Roman Podoliaka
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
High
MOS Nova
Mirantis OpenStack 6.1
5.1.x
Fix Released
High
Alex Ermolov
Mirantis OpenStack 5.1.1-mu-1
6.0.x
Fix Released
High
MOS Nova
Mirantis OpenStack 6.0-updates
6.1.x
Fix Released
High
MOS Nova
Mirantis OpenStack 6.1

Bug Description

Upstream bug: https://bugs.launchpad.net/nova/+bug/1363324

Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

We need a back port of https://review.openstack.org/#/c/121259/2 for 5.1-updates, 5.1.1-updates and 5.0-updates branches

Changed in mos:
status: Triaged → Fix Committed
Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package nova has been built for project openstack/nova
Package version == 2014.1.3, package release == fuel5.1.1.mira7.git.cd7f3ba.7ad20ad

Changeset: https://review.fuel-infra.org/5331
project: openstack/nova
branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
author: Alex Ermolov
committer: Alex Ermolov
subject: correct inverted subtraction in quota check
status: patchset-created

Files placed on repository:
openstack-nova-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-api-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-cells-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-cert-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-common-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-compute-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-conductor-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-console-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-doc-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-network-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-novncproxy-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-objectstore-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
openstack-nova-scheduler-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm
python-nova-2014.1.3-fuel5.1.1.mira7.git.cd7f3ba.7ad20ad.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1.1-updates-stable-5331/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package nova has been built for project openstack/nova
Package version == 2014.1.1, package release == fuel5.1.mira9.git.bd1be1b.51a3c0e

Changeset: https://review.fuel-infra.org/5332
project: openstack/nova
branch: openstack-ci/fuel-5.1-updates/2014.1.1
author: Alex Ermolov
committer: Alex Ermolov
subject: correct inverted subtraction in quota check
status: patchset-created

Files placed on repository:
openstack-nova-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-api-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-cells-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-cert-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-common-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-compute-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-conductor-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-console-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-doc-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-network-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-novncproxy-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-objectstore-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
openstack-nova-scheduler-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm
python-nova-2014.1.1-fuel5.1.mira9.git.bd1be1b.51a3c0e.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-updates-stable-5332/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package nova has been built for project openstack/nova
Package version == 2014.1.3, package release == fuel5.1.1~mira5+git.cd7f3ba.7ad20ad

Changeset: https://review.fuel-infra.org/5331
project: openstack/nova
branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
author: Alex Ermolov
committer: Alex Ermolov
subject: correct inverted subtraction in quota check
status: patchset-created

Files placed on repository:
nova-ajax-console-proxy_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-api-ec2_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-api-metadata_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-api-os-compute_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-api-os-volume_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-api_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-baremetal_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-cells_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-cert_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-common_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-compute-kvm_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-compute-libvirt_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-compute-lxc_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-compute-qemu_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-compute-vmware_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-compute-xen_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-compute_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-conductor_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-console_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-consoleauth_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-doc_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-network_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-novncproxy_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-objectstore_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-scheduler_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-spiceproxy_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-volume_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
nova-xvpvncproxy_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb
python-nova_2014.1.3-fuel5.1.1~mira5+git.cd7f3ba.7ad20ad_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-5.1.1-updates-stable-5331/ubuntu

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package nova has been built for project openstack/nova
Package version == 2014.1.1, package release == fuel5.1~mira23+git.bd1be1b.51a3c0e

Changeset: https://review.fuel-infra.org/5332
project: openstack/nova
branch: openstack-ci/fuel-5.1-updates/2014.1.1
author: Alex Ermolov
committer: Alex Ermolov
subject: correct inverted subtraction in quota check
status: patchset-created

Files placed on repository:
nova-ajax-console-proxy_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-api-ec2_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-api-metadata_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-api-os-compute_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-api-os-volume_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-api_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-baremetal_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-cells_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-cert_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-common_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-compute-kvm_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-compute-libvirt_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-compute-lxc_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-compute-qemu_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-compute-vmware_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-compute-xen_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-compute_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-conductor_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-console_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-consoleauth_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-doc_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-network_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-novncproxy_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-objectstore_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-scheduler_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-spiceproxy_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-volume_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
nova-xvpvncproxy_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb
python-nova_2014.1.1-fuel5.1~mira23+git.bd1be1b.51a3c0e_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-5.1-updates-stable-5332/ubuntu

Denis Klepikov (dklepikov)
tags: added: customer-found
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/nova (openstack-ci/fuel-5.1-updates/2014.1.1)

Reviewed: https://review.fuel-infra.org/5332
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-5.1-updates/2014.1.1

Commit: bd1be1bcc92f0c84eb9881afe1da74e0f3bc9a28
Author: Alex Ermolov <email address hidden>
Date: Mon Apr 6 14:31:00 2015

correct inverted subtraction in quota check

From a user reported bug: we were doing the subtraction backwards
here, causing int overflow, causing all kinds of invalid. Instead
actually subtract the smaller number from the bigger number.

Change-Id: I7c099df5e31aa25b8be65c570e2e0b8a3e93c277
Closes-Bug: #1440740

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/nova (openstack-ci/fuel-5.1.1-updates/2014.1.1)

Change abandoned by Alex Ermolov <email address hidden> on branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
Review: https://review.fuel-infra.org/5331

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change restored on openstack/nova (openstack-ci/fuel-5.1.1-updates/2014.1.1)

Change restored by Alex Ermolov <email address hidden> on branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
Review: https://review.fuel-infra.org/5331

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/nova (openstack-ci/fuel-5.1.1-updates/2014.1.1)

Fix proposed to branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
Change author: Alex Ermolov <email address hidden>
Review: https://review.fuel-infra.org/9382

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/nova (openstack-ci/fuel-5.1.1-updates/2014.1.1)

Change abandoned by Alex Ermolov <email address hidden> on branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
Review: https://review.fuel-infra.org/5331

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/nova (openstack-ci/fuel-5.1.1-updates/2014.1.1)

Reviewed: https://review.fuel-infra.org/9382
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-5.1.1-updates/2014.1.1

Commit: af982ad41d807ada42852761ca86e08ad5432092
Author: Alex Ermolov <email address hidden>
Date: Mon Jul 20 09:02:29 2015

correct inverted subtraction in quota check

From a user reported bug: we were doing the subtraction backwards
here, causing int overflow, causing all kinds of invalid. Instead
actually subtract the smaller number from the bigger number.

Change-Id: Ia4899a77314bdff58979e177d7987485f66c3ac0
Closes-Bug: #1440740

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.