infobars color disabled (needs theme update)

[Sadi Yumuşak]

For some time now I don't see any bgcolor for Nautilus infobar (e.g. Trash infobar containg the 3rd Trash title as well as Restore and Empty button) in most GTK themes, even including Ambiance, under Ubuntu 14.10.
I've been told that the problem also exists in the latest beta version of Ubuntu 15.04.
I understand that this is caused by this patch:
http://bazaar.launchpad.net/%7Eubuntu-desktop/nautilus/ubuntu/view/head:/debian/patches/ubuntu_infobars_color.patch

[Sebastien Bacher (seb128)]

Thanks, that's not really a bug. Before that change the bar for e.g removable medias or the trash were blue and looking out of place. What color would you expect to be used?

[Sadi Yumuşak (sa-yu)]

I don't know. You might be right. I wouldn't expect that area to be left sort of blank but filled with a very light shade of some color that would fit in with the theme. And when I mentioned about this a themer suggested to me that it might be bug caused by that patch, but then implemented a bgcolor by inserting a couple of lines to the relevant css file (although they said some bgcolor was displayed in other distros).

[Sebastien Bacher (seb128)]

right, upstream displays some color, see bug #1259059 for details of why it was changed in Ubuntu

before it looked like
https://launchpadlibrarian.net/158804218/ko%C5%A1.png

the blue is out of place with our style

We could probably change the "question" color in the theme but we would have to pick a good color for those...

[Sadi Yumuşak (sa-yu)]

I'm not an expert in these matters but it seems to me that the problem in bug #1259059 could have been better addressed by fixing ubuntu-themes (instead of the patch above) so that they use yellow (info) for GtkInfoBar and not blue (question).

[Sebastien Bacher (seb128)]

If you look at the patch you can notice that it replaces GTK_MESSAGE_QUESTION which is what upstream is using, by GTK_MESSAGE_OTHER. Your suggestion is to use the info type, that doesn't need a theme change, just to change the type to INFO rather than OTHER. That might be a valid suggestion, I'm unsure how the yellow would fit though...

[Sadi Yumuşak (sa-yu)]

So I understand that in this case it might also be worthwhile to ask Nautilus developers to consider using GTK_MESSAGE_INFO there (I don't even know if it exists) instead of GTK_MESSAGE_QUESTION, and then it would be up to the themers to decide what color code to use for such infobars; yellow or whatever that they think would fit best.

[Sebastien Bacher (seb128)]

Right, that's a good summary. What pushed me to do the change we are currently using is that nobody from the design/UI team was available to discuss the theme change and I didn't want to get blocked on that to improve the situation, we should still look at doing the correct fix though, thanks for the reminder!