Neutron client plugin error when resolving attribute

[Randall Burt]

If a Neutron resource fails and the user tries to resolve attributes for the resource (heat resource-show for example), the client plugin attempts to retrieve the data from Neutron with an id of None. This can cause an exception other than NotFound which causes odd exceptions to be raised. Also, the test for this functionality is limited and doesn't actually test that the attributes resolve to None *only* on a NotFound.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170600

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170600
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c0f3f851c3787fc95fa450430db7a52314ee6d01
Submitter: Jenkins
Branch: master

commit c0f3f851c3787fc95fa450430db7a52314ee6d01
Author: Randall Burt <email address hidden>
Date: Fri Apr 3 15:17:07 2015 -0500

    Do not resolve neutron resource attributes when resource_id is None

    Also, fix the test to correctly account for NotFound as well as
    this new case.

    Closes-Bug: 1440189
    Change-Id: I31004c11af71e32a4388fd44cd8b98df8afbd1a5