openstackdocstheme sphinx theme doesn't insert padding after a table

[Tom Fifield]

If you have a table followed by a code block, the theme will render them as directly next to each other. I think it makes sense to have at least a small amount of space between the bottom of the table and the next block

To test - something like this:

========== ====================== =============================
Parameter Description Values
========== ====================== =============================
cake cake cake
========== ====================== =============================

.. code-block:: python
    pass

[Bernd Bausch (berndbausch)]

This is not limited to a code block after a table, but also a normal text paragraph after a table <p>. My guess is that any element will follow a table without sufficient space.

Using pure Sphinx without openstackdocstheme, there is a space. Firebug reveals that the table itself has no margins around it, but a paragraph coming after a table has an upper and a lower margin. With openstackdocstheme, the paragraph has no upper margin, which explains the lack of vertical space.

I would investigate how upper margins can be added to all affected elements and if this would break openstackdocstheme somewhere else. Right now I can't commit the time for this.

[Tom Fifield (fifieldt)]

Thanks for the excellent detective work, Bernd!

[Bernd Bausch (berndbausch)]

bootstrap.min.css explicitly sets the top margin of a paragraph to 0:

p {
 margin:0 0 10px
}

Changing the first 0 to 10px immediately has the wanted effect.

Margins around code blocks are defined in a different way I don't understand yet.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/232427

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232427
Committed: https://git.openstack.org/cgit/openstack/openstackdocstheme/commit/?id=9d1a9699cd84e785a141af453e0daef20e36fc26
Submitter: Jenkins
Branch: master

commit 9d1a9699cd84e785a141af453e0daef20e36fc26
Author: Bernd <email address hidden>
Date: Thu Oct 8 18:03:36 2015 +0900

    Add table padding to openstackdocstheme CSS

    This patch adds white space below a table to make it look nicer.

    Change-Id: I7148ba6dc1e0e01ee0eceeb3a90bcc2591c0b0c5
    Closes-Bug: #1439918