Ironic: CONF.scheduler_use_baremetal_filters doesn't have any effect

Bug #1439868 reported by Jim Rollenhagen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Jim Rollenhagen

Bug Description

When CONF.scheduler_use_baremetal_filters is set, and IronicHostManager is in use, the default scheduler filters should be as defined by CONF.baremetal_scheduler_default_filters. This is done in IronicHostManager's __init__ method.

However, __init__ calls the superclass' __init__ method before setting the default filters, and so the change isn't picked up by the base HostManager. Thus this setting does nothing.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170299

Changed in nova:
assignee: nobody → Jim Rollenhagen (jim-rollenhagen)
status: New → In Progress
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/170299
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c4dc66994c5548afa4a13b42069d77435b6df6bb
Submitter: Jenkins
Branch: master

commit c4dc66994c5548afa4a13b42069d77435b6df6bb
Author: Jim Rollenhagen <email address hidden>
Date: Thu Apr 2 14:55:18 2015 -0700

    Respect CONF.scheduler_use_baremetal_filters

    This fixes an issue where the default filters are loaded before
    IronicHostManager overrides the default, which is the intended behavior
    when CONF.scheduler_use_baremetal_filters is True.

    Creates a _load_filters method on the base HostManager class that
    returns a list of filters to be loaded at initialization, and overrides
    it in IronicHostManager to return the default baremetal filters when
    scheduler_use_baremetal_filters is set.

    Change-Id: I1801c62d85665a6a3423428e91e1aeeb546613d7
    Closes-Bug: #1439868

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.