If unexpected error appears when you build plugin, folder "???<plugin_name>???" appears

[Anastasia Palkina]

"build_id": "2015-03-31_22-54-44",
"ostf_sha": "1c7f799cb0e159737d1f910b13e4073b16d1eb8c",
"build_number": "260",
"release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-03-31_22-54-44", "ostf_sha": "1c7f799cb0e159737d1f910b13e4073b16d1eb8c", "build_number": "260", "api": "1.0", "nailgun_sha": "51ddbe0a2e379e82af531b1c6d45fd386d2f894e", "production": "docker", "python-fuelclient_sha": "9b0b6ab2f09ff75445550b7210104e21df5d8cd6", "astute_sha": "7292fc2a673cb1c32a688a46fd4836ca0500a957", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "178812b1971a900c49a8afc1688afd7475a6ffbb", "fuellib_sha": "27459a89cdac078ec4046a442a11d750c5eccc2e"}}},
"auth_required": true,
"api": "1.0",
"nailgun_sha": "51ddbe0a2e379e82af531b1c6d45fd386d2f894e",
"production": "docker",
"python-fuelclient_sha": "9b0b6ab2f09ff75445550b7210104e21df5d8cd6",
"astute_sha": "7292fc2a673cb1c32a688a46fd4836ca0500a957",
"feature_groups": ["mirantis"],
"release": "6.1",
"fuelmain_sha": "178812b1971a900c49a8afc1688afd7475a6ffbb",
"fuellib_sha": "27459a89cdac078ec4046a442a11d750c5eccc2e"

1. dockerctl shell nailgun
2. yum install -y vi git createrepo rpm dpkg-devel tar
3. git clone https://github.com/stackforge/fuel-plugins
4. cd fuel-plugins/fuel_plugin_builder
5. python setup.py sdist
6. pip install dist/fuel-plugin-builder-2.0.0.dev.tar.gz
7. fpb --create ‘shell_timeout’
8. cd ~
9.
[root@fuel ~]# fpb --build shell_timeout
Unexpected error
[Errno 2] No such file or directory: 'shell_timeout/metadata.yaml'

10. cd fuel-plugins/fuel_plugin_builder/
11. fpb --build .
12.
[root@fuel fuel_plugin_builder]# ls -la
total 56
drwxr-xr-x 8 root root 4096 Apr 2 15:11 .
drwxr-xr-x 7 root root 4096 Apr 2 11:19 ..
-rw-r--r-- 1 root root 2075 Apr 2 11:19 CHANGELOG.md
-rw-r--r-- 1 root root 70 Apr 2 11:19 MANIFEST.in
drwxr-xr-x 2 root root 4096 Apr 2 11:19 dist
drwxr-xr-x 6 root root 4096 Apr 2 11:19 fuel_plugin_builder
drwxr-xr-x 2 root root 4096 Apr 2 11:19 fuel_plugin_builder.egg-info
drwxr-xr-x 5 root root 4096 Apr 2 15:12 install_test
-rw-r--r-- 1 root root 70 Apr 2 11:19 requirements.txt
-rw-r--r-- 1 root root 1852 Apr 2 11:19 setup.py
drwxr-xr-x 5 root root 4096 Apr 2 11:42 shell_timeout
-rw-r--r-- 1 root root 86 Apr 2 11:19 test-requirements.txt
-rw-r--r-- 1 root root 695 Apr 2 11:19 tox.ini
drwxr-xr-x 4 root root 4096 Apr 2 11:20 ???shell_timeout???

Folder ???shell_timeout??? appears

[root@fuel fuel_plugin_builder]# cd ???shell_timeout???
[root@fuel ‘shell_timeout’]# ls -la
total 44
drwxr-xr-x 4 root root 4096 Apr 2 11:20 .
drwxr-xr-x 8 root root 4096 Apr 2 15:11 ..
-rw-r--r-- 1 root root 18 Apr 2 11:20 .gitignore
-rw-r--r-- 1 root root 11325 Apr 2 11:20 LICENSE
-rw-r--r-- 1 root root 0 Apr 2 11:20 README.md
-rw-r--r-- 1 root root 47 Apr 2 11:20 README.md.mako
drwxr-xr-x 2 root root 4096 Apr 2 11:20 deployment_scripts
-rw-r--r-- 1 root root 168 Apr 2 11:20 environment_config.yaml.mako
-rw-r--r-- 1 root root 204 Apr 2 11:20 pre_build_hook
drwxr-xr-x 4 root root 4096 Apr 2 11:20 repositories
[root@fuel ‘shell_timeout’]# cd ..
[root@fuel fuel_plugin_builder]# cd shell_timeout/
[root@fuel shell_timeout]# ls -la
total 72
drwxr-xr-x 5 root root 4096 Apr 2 11:42 .
drwxr-xr-x 8 root root 4096 Apr 2 15:11 ..
drwxr-xr-x 4 root root 4096 Apr 2 11:42 .build
-rw-r--r-- 1 root root 18 Apr 2 11:20 .gitignore
-rw-r--r-- 1 root root 11325 Apr 2 11:20 LICENSE
-rw-r--r-- 1 root root 46 Apr 2 11:22 README.md
drwxr-xr-x 2 root root 4096 Apr 2 11:22 deployment_scripts
-rw-r--r-- 1 root root 167 Apr 2 11:22 environment_config.yaml
-rw-r--r-- 1 root root 1066 Apr 2 11:22 metadata.yaml
-rw-r--r-- 1 root root 204 Apr 2 11:20 pre_build_hook
drwxr-xr-x 4 root root 4096 Apr 2 11:22 repositories
-rw-r--r-- 1 root root 15086 Apr 2 11:42 shell_timeout-1.0-1.0.0-0.noarch.rpm
-rw-r--r-- 1 root root 108 Apr 2 11:32 tasks.yaml

[Vladimir Sharshov (vsharshov)]

[root@fuel ~]# ls
fuel-plugins shell_timeout ?shell_timeout ???shell_timeout???

[Evgeniy L (rustyrobot)]

"???" symbols are there, because there are used unexpected symbols from linux encoding point of view.
When I tried to run the same command I got

    Unexpected error
    'ascii' codec can't decode byte 0xe2 in position 0: ordinal not in range(128)

Probably we should add some validation for that.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178279

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178279
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=4228d21f3a92d3b23bad7ffd73cdcd8939d6cc3a
Submitter: Jenkins
Branch: master

commit 4228d21f3a92d3b23bad7ffd73cdcd8939d6cc3a
Author: Andriy Popovych <email address hidden>
Date: Tue Apr 28 19:32:13 2015 +0300

    Add checking for name during plugin creation

    Currently plugin builder can verify correctness only
    after plugin was created. It gives to user possibility
    creates plugin with incorrect name. This fix provides
    validation for name on creation stage.

    Change-Id: Ib54313fac6b246288838e48ce483046e47a5a7bb
    Closes-Bug: #1439760