hacking

Hacking checks for logging guidelines

Bug #1439709 reported by Ivan Kolodyazhny
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
hacking
Confirmed
Undecided
Unassigned

Bug Description

Now Cinder, Nova and Neutron have own hacking checks for logging guidelines [1], [2]. We need to move this checks to hacking

[1] http://docs.openstack.org/developer/oslo.log/usage.html#general-logging-guidelines
[2] http://docs.openstack.org/developer/oslo.log/usage.html#migrating-to-oslo-log

Ivan Kolodyazhny (e0ne)
Changed in hacking:
status: New → Confirmed
assignee: nobody → Ivan Kolodyazhny (e0ne)
Revision history for this message
Joe Gordon (jogo) wrote :

One of the issues with these rules is they assume LOG is the logger which may not always be the case, and not sure that is an assumption we should make.

https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L79

Revision history for this message
Ian Cordasco (icordasc) wrote :

These might be good candidates for off-by-default rules that projects can opt into.

Changed in hacking:
assignee: Ivan Kolodyazhny (e0ne) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.