Remove redundant logic on read-only volume in VNX Cinder Driver

[Jeegn Chen]

The logic on read-only volume in cinder/volume/drivers/emc/emc_vnx_cli.py is duplicate to the logic in cinder/volume/manager.py.

The logic in cinder/volume/drivers/emc/emc_vnx_cli.py is useless and should be removed.

cinder/volume/drivers/emc/emc_vnx_cli.py
def initialize_connection(self, volume, connector):
    volume_metadata = {}
    for metadata in volume['volume_admin_metadata']:
        volume_metadata[metadata['key']] = metadata['value']
    access_mode = volume_metadata.get('attached_mode')
    if access_mode is None:
        access_mode = ('ro'
                       if volume_metadata.get('readonly') == 'True'
                       else 'rw')
    LOG.debug('Volume %(vol)s Access mode is: %(access)s.',
              {'vol': volume['name'],
               'access': access_mode})
 # Add access_mode to connection info

cinder/volume/manager.py
volume_metadata = self.db.volume_admin_metadata_get(context.elevated(),
                                                    volume_id)
if conn_info['data'].get('access_mode') is None:
    access_mode = volume_metadata.get('attached_mode')
    if access_mode is None:
        # NOTE(zhiyan): client didn't call 'os-attach' before
        access_mode = ('ro'
                       if volume_metadata.get('readonly') == 'True'
                       else 'rw')
    conn_info['data']['access_mode'] = access_mode

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/173183

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/173183
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=07d8c04a0e4e1d482e8ec8aed3e05821509447de
Submitter: Jenkins
Branch: master

commit 07d8c04a0e4e1d482e8ec8aed3e05821509447de
Author: Jeegn Chen <email address hidden>
Date: Tue Apr 14 14:19:12 2015 +0800

    Remove redundant code from VNX Cinder Driver

    The logic on read-only volume in cinder/volume/drivers/emc/emc_vnx_cli.py
    is duplicate to the logic in cinder/volume/manager.py. This patch is to
    remove it.

    Change-Id: Ib1a740a6065dbc8f3412d9dcf2e0d9025ab32d87
    Closes-Bug: #1439531