MAAS

"Choose power type" dropdown broken in FF

Bug #1439339 reported by Carla Berkers
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Blake Rouse
MAAS 1.8.0

Bug Description

In trunk, when I add an installable machine or chassis, the "Power type" dropdown has a red outline and has no interaction.

Since I can't select a powertype, I cannot add new nodes.

Tags: ui

Related branches

lp:~blake-rouse/maas/disable-firefox-dbl-click-overlay
Gavin Panella (community): Approve
Diff: 337 lines (+225/-67)
5 files modified
src/maasserver/context_processors.py (+1/-0)
src/maasserver/static/js/angular/directives/dbl_click_overlay.js (+79/-67)
src/maasserver/static/js/angular/directives/tests/test_dbl_click_overlay.js (+20/-0)
src/maasserver/static/js/angular/services/browser.js (+49/-0)
src/maasserver/static/js/angular/services/tests/test_browser.js (+76/-0)
Revision history for this message
Carla Berkers (carlaberkers) wrote :

The cluster dropdown on node details is broken too, and the dropdown on cluster details isn't - suggesting this is an issue with the wrapper.

This bug occurs in FF but not in chrome.

Revision history for this message
Blake Rouse (blake-rouse) wrote :

This is an issue with the double click wrapper, that allows a user to double click an input to enter edit mode. The click event for the dropdown is being sent incorrectly on firefox.

Changed in maas:
status: New → Triaged
importance: Undecided → Critical
milestone: none → 1.8.0
assignee: nobody → Blake Rouse (blake-rouse)
summary: - "Choose power type" dropdown broken
+ "Choose power type" dropdown broken in FF
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Doesn't look like the double click wrapper is going to work on firefox at all. Will disable it on firefox, but we can allow it on other browsers.

Revision history for this message
Carla Berkers (carlaberkers) wrote :

We said that if you'd have time, we change from double click to single click anyway.

Will single click work in FF?

Revision history for this message
Blake Rouse (blake-rouse) wrote :

No that will not work either. It has nothing to do with the click and everything to do with the ability to send a click event to the underlying select element. In Firefox this is not supported at all. In other browsers you can craft a mousedown event to send to the select element.

Best we can do now is disable it in Firefox. Without disabling it then no selects using the overlay will work.

MAAS Lander (maas-lander)
Changed in maas:
status: Triaged → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.