Don’t allow Skyhawk P1 firmware to be downloaded to Skyhawk P2 cards

[Brian Fromme]

Sureshkumar Reddy Reddygari (~suresh-reddy) writes:

Skyhawk P1 firmware can be downloaded to Skyhawk P2 cards. Skyhawk-P1 FW UFI is not compatible to flash on Skyhawk-P2 ASIC. These patches will avoid flashing P1 firmware on P2 card.

We have a number of OEMs rolling on Skyhawk P2 ASIC support for their adapters over the next 6-12 months. We need to ensure this fix gets in in order to prevent Skyhawk B0 ASIC images being inadvertently downloaded to the P2 ASICs.

If a B0 image is downloaded to a P2 ASIC, it will boot and run but the functionality will not operate correctly.

All of the traditional Tier 1 Server vendors are rolling out the P2 ASIC in the coming year and are in qual now. Please consider including this change as an exception into 14.04 Stable release update and 14.04.3 once that git tree is available.

[Brian Fromme (brianfromme)]

Following three patches are not there ubuntu-vivid tree. These patches required
to fix this issue.

sureshr@ubuntu:~/ubuntu-vivid/drivers/net/ethernet/emulex/benet$ git log .
commit 4fd8965cd846a4cc2c5cf8b4d7cd5708b83ee193
Author: Vasundhara Volam <email address hidden>
Date: Fri Feb 6 08:18:38 2015 -0500

    be2net: avoid flashing SH-B0 UFI image on SH-P2 chip

    Skyhawk-B0 FW UFI is not compatible to flash on Skyhawk-P2 ASIC.
    But, Skyhawk-P2 FW UFI is compatible with both B0 and P2 chips.

    Signed-off-by: Vasundhara Volam <email address hidden>
    Signed-off-by: Sathya Perla <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>
    Signed-off-by: Suresh Reddy <email address hidden>

commit 73bc2aad5115e701bbe01d6b13a111190aa1feab
Author: Vasundhara Volam <email address hidden>
Date: Fri Feb 6 08:18:37 2015 -0500

    be2net: refactor code that checks flash file compatibility

    This patch re-factors the code that checks for flash file compatibility
with
    the chip type, for better readability, as follows:
        - be_get_ufi_type() returns the UFI type from the flash file
        - be_check_ufi_compatibility() checks if the UFI type is compatible
          with the adapter/chip that is being flashed

    Signed-off-by: Vasundhara Volam <email address hidden>
    Signed-off-by: Sathya Perla <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>
    Signed-off-by: Suresh Reddy <email address hidden>

commit 7b2093eb5d316736adf0c5517e4b4a8196e49942
Author: Vasundhara Volam <email address hidden>
Date: Tue Jan 20 03:51:48 2015 -0500

    be2net: move definitions related to FW cmdsfrom be_hw.h to be_cmds.h

    Some FW cmd related definitions were included in be_hw.h

    Signed-off-by: Vasundhara Volam <email address hidden>
    Signed-off-by: Sathya Perla <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>
    Signed-off-by: Suresh Reddy <email address hidden>

[Brad Figg (brad-figg)]

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1439332

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 3.19.0-12.12

---------------
linux (3.19.0-12.12) vivid; urgency=low

  [ Andy Whitcroft ]

  * [Packaging] do_common_tools should always be on
  * [Packaging] Provides: virtualbox-guest-modules when appropriate
    - LP: #1434579

  [ Chris J Arges ]

  * Revert "SAUCE: ext4: disable ext4_punch_hole for indirect filesystems"
    - LP: #1292234

  [ Leann Ogasawara ]

  * Release Tracking Bug
    - LP: #1439803

  [ Timo Aaltonen ]

  * SAUCE: i915_bpo: Provide a backport driver for Skylake & Cherryview
    graphics
    - LP: #1420774
  * SAUCE: i915_bpo: Update intel_ips.h file location
    - LP: #1420774
  * SAUCE: i915_bpo: Only support Skylake and Cherryview with the backport
    driver
    - LP: #1420774
  * SAUCE: i915_bpo: Rename the backport driver to i915_bpo
    - LP: #1420774
  * i915_bpo: [Config] Enable CONFIG_DRM_I915_BPO=m
    - LP: #1420774
  * SAUCE: i915_bpo: Add i915_bpo_*() calls for ubuntu/i915
    - LP: #1420774
  * SAUCE: i915_bpo: Revert "drm/i915: remove unused
    power_well/get_cdclk_freq api"
    - LP: #1420774
  * SAUCE: i915_bpo: Add i915_bpo specific power well calls
    - LP: #1420774
  * SAUCE: Backport I915_PARAM_MMAP_VERSION and I915_MMAP_WC
    - LP: #1420774
  * SAUCE: Partial backport of drm/i915: Add ioctl to set per-context
    parameters
    - LP: #1420774
  * SAUCE: drm/i915: Specify bsd rings through exec flag
    - LP: #1420774
  * SAUCE: drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam
    - LP: #1420774
  * SAUCE: drm/i915: add component support
    - LP: #1420774
  * SAUCE: drm/i915: Add tiled framebuffer modifiers
    - LP: #1420774
  * SAUCE: Backport new displayable tiling formats
    - LP: #1420774
  * SAUCE: Backport drm_crtc_vblank_reset() helper
    - LP: #1420774
  * SAUCE: drm/i915: Add I915_PARAM_REVISION
    - LP: #1420774
  * SAUCE: drm/i915: Export total subslice and EU counts
    - LP: #1420774
  * SAUCE: i915_bpo: Revert drm/mm: Support 4 GiB and larger ranges
    - LP: #1420774

  [ Upstream Kernel Changes ]

  * drm/i915/skl: Split the SKL PCI ids by GT
    - LP: #1420774
  * drm: Reorganize probed mode validation
    - LP: #1420774
  * drm: Perform basic sanity checks on probed modes
    - LP: #1420774
  * drm: Do basic sanity checks for user modes
    - LP: #1420774
  * drm/atomic-helper: Export both plane and modeset check helpers
    - LP: #1420774
  * drm/atomic-helper: Again check modeset *before* plane states
    - LP: #1420774
  * drm/atomic: Introduce state->obj backpointers
    - LP: #1420774
  * drm: allow property validation for refcnted props
    - LP: #1420774
  * drm: store property instead of id in obj attachment
    - LP: #1420774
  * drm: get rid of direct property value access
    - LP: #1420774
  * drm: add atomic_set_property wrappers
    - LP: #1420774
  * drm: tweak getconnector locking
    - LP: #1420774
  * drm: add atomic_get_property
    - LP: #1420774
  * drm: Remove unneeded braces for single statement blocks
    - LP: #1420774
  * drm: refactor getproperties/getconnector
    - LP: #1420774
  * drm: add atomic properties
    - LP: #1420774
  * drm/atomic: atomic_check functions
    - LP: #1420774
  * drm: s...