Don’t allow Skyhawk P1 firmware to be downloaded to Skyhawk P2 cards
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
High
|
Leann Ogasawara |
Bug Description
Sureshkumar Reddy Reddygari (~suresh-reddy) writes:
Skyhawk P1 firmware can be downloaded to Skyhawk P2 cards. Skyhawk-P1 FW UFI is not compatible to flash on Skyhawk-P2 ASIC. These patches will avoid flashing P1 firmware on P2 card.
We have a number of OEMs rolling on Skyhawk P2 ASIC support for their adapters over the next 6-12 months. We need to ensure this fix gets in in order to prevent Skyhawk B0 ASIC images being inadvertently downloaded to the P2 ASICs.
If a B0 image is downloaded to a P2 ASIC, it will boot and run but the functionality will not operate correctly.
All of the traditional Tier 1 Server vendors are rolling out the P2 ASIC in the coming year and are in qual now. Please consider including this change as an exception into 14.04 Stable release update and 14.04.3 once that git tree is available.
tags: | added: patch |
Changed in linux (Ubuntu): | |
assignee: | nobody → Leann Ogasawara (leannogasawara) |
importance: | Undecided → High |
status: | Incomplete → In Progress |
Changed in linux (Ubuntu): | |
status: | In Progress → Fix Committed |
Following three patches are not there ubuntu-vivid tree. These patches required
to fix this issue.
sureshr@ ubuntu: ~/ubuntu- vivid/drivers/ net/ethernet/ emulex/ benet$ git log . c2c5cf8b4d7cd57 08b83ee193
commit 4fd8965cd846a4c
Author: Vasundhara Volam <email address hidden>
Date: Fri Feb 6 08:18:38 2015 -0500
be2net: avoid flashing SH-B0 UFI image on SH-P2 chip
Skyhawk-B0 FW UFI is not compatible to flash on Skyhawk-P2 ASIC.
But, Skyhawk-P2 FW UFI is compatible with both B0 and P2 chips.
Signed-off-by: Vasundhara Volam <email address hidden>
Signed-off-by: Sathya Perla <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
Signed-off-by: Suresh Reddy <email address hidden>
commit 73bc2aad5115e70 1bbe01d6b13a111 190aa1feab
Author: Vasundhara Volam <email address hidden>
Date: Fri Feb 6 08:18:37 2015 -0500
be2net: refactor code that checks flash file compatibility
This patch re-factors the code that checks for flash file compatibility ufi_compatibili ty() checks if the UFI type is compatible
with
the chip type, for better readability, as follows:
- be_get_ufi_type() returns the UFI type from the flash file
- be_check_
with the adapter/chip that is being flashed
Signed-off-by: Vasundhara Volam <email address hidden>
Signed-off-by: Sathya Perla <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
Signed-off-by: Suresh Reddy <email address hidden>
commit 7b2093eb5d31673 6adf0c5517e4b4a 8196e49942
Author: Vasundhara Volam <email address hidden>
Date: Tue Jan 20 03:51:48 2015 -0500
be2net: move definitions related to FW cmdsfrom be_hw.h to be_cmds.h
Some FW cmd related definitions were included in be_hw.h
Signed-off-by: Vasundhara Volam <email address hidden>
Signed-off-by: Sathya Perla <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
Signed-off-by: Suresh Reddy <email address hidden>