GlanceClientWrapper's onetime 'call' dosn't work with glance client V2

Bug #1439275 reported by Anton Arefiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Anton Arefiev

Bug Description

 When we use GlanceClientWrapper's method 'call' with onetime glance V2, we can pass glance api version throw args:
def call(self, context, method, *args, **kwargs):
    version = self.version
        if version in kwargs:
            version = kwargs['version']

But condition in if statement is always false, because 'version' val stored in dict is string, and var chacked in call is None or int.

Anton Arefiev (aarefiev)
Changed in cinder:
assignee: nobody → Anton Arefiev (aarefiev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169831

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/169831
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=486da4305d607b32b03709c6b0f26430776a37cf
Submitter: Jenkins
Branch: master

commit 486da4305d607b32b03709c6b0f26430776a37cf
Author: Anton Arefiev <email address hidden>
Date: Wed Apr 1 19:14:26 2015 +0300

    Fix always false condition in glance wrapper

    If statement's condition in GlanceClientWrapper's method 'call'
    always false, because 'version' key passed through kwargs is
    string, and variable chacked in 'call' is None or int.

    Change-Id: Ief1e8d2c41aaa774666bc59d63cdea68f80f308a
    Closes-Bug: #1439275

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.