Nailgun statistics module needs refactoring

Bug #1439268 reported by Artem Roma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Artem Roma

Bug Description

Statistics collecting feature performs two separate logical tasks: collecting of the statistics of the fuel infrastructure using and collecting info about oswl resources. As for now code for both of that tasks are mixed in one package (nailgun.statistics) which perplexing structure make it hard (for example) to reuse same (utility) code in both parts without additional refactoring effort. For simplifying of managing of the statistics' codebase we should create subpackages where code coupled with same logic will be placed and move utility infrastructure (helper functions, custom errors definition etc.) on higher level.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169800

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/169800
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4603980b81ba6bec952b31cb7255de2ceb49720a
Submitter: Jenkins
Branch: master

commit 4603980b81ba6bec952b31cb7255de2ceb49720a
Author: Artem Roma <email address hidden>
Date: Wed Apr 1 18:09:58 2015 +0300

    Refactor nailgun.statistics package

    Two subpackages (for statistic collecting of fuel infrastructure using
    and collecting of oswl info) created in order to separate code dedicated
    to logically different functions. Utility (universal utility functions
    and custom errors description) infrastructure left on
    statistics package level with possibility of reusing in subpackages'
    code. Tests refactored considering current separation.

    Change-Id: I89509d5fcd224276c3cd6c95353cea0ebca2162e
    Closes-Bug: #1439268

Changed in fuel:
status: In Progress → Fix Committed
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.