L3 router plugin for MLX fails to add router interface for the first time

[Pradeep Sathasivam]

Call to add_router_interface without specifying ‘Fixed IP’ fails 1st time and the q-svc logs show db timeout and deadlock. Subsequent calls have no issues.

Add unit test code which also covers negative test case.

Rename l3_router_fi_ni_plugin.py --> l3_router_plugin.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/172358

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172358
Committed: https://git.openstack.org/cgit/stackforge/networking-brocade/commit/?id=20aea72cfcd266986ba7f2849937d08bb30ffd3e
Submitter: Jenkins
Branch: master

commit 20aea72cfcd266986ba7f2849937d08bb30ffd3e
Author: Pradeep Sathasivam <email address hidden>
Date: Fri Apr 10 15:12:03 2015 +0530

    Removed built-in transaction support

    The below statement has some issues due to which router interface
    was not added for the first time.

    with context.session.begin(subtransactions=True):

    The above statement is removed and transaction is handled like we do
    it in ML2 plugin code. We call super.remove_router_interface in case
    of an exception

    Also added negative unit test cases and enabled L3 tests in
    test_discover module

    Renamed the following modules:
    l3_router_fi_ni_plugin.py to l3_router_plugin.py
    test_brocade_l3_router_fi_ni_plugin.py to test_l3_router_plugin.py

    Change-Id: Id0de71c758c3c271cc54ed00a5014e7e2fc6609d
    Closes-Bug: #1439095

[OpenStack Infra (hudson-openstack)]

Change abandoned by Pradeep Sathasivam (<email address hidden>) on branch: master
Review: https://review.openstack.org/165827
Reason: I have split up this review into multiple review, hence abandoning this review.