Keybinding "switch-window-backward" not works

Bug #1439081 reported by fasheng
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Gala
Fix Released
Medium
fasheng

Bug Description

Hi,

I found that the code to fix "switch-applications-backward" keybinding issue in src/Widgets/WindowSwitcher.vala cause "switch-window-backward" not works. I wrote a patch for it, hope that help.

And thanks for the amazing work of Elementary OS, have a good time!

Related branches

Revision history for this message
fasheng (fasheng-xu) wrote :
Revision history for this message
Hernan Keena (hpk2987) wrote :

Yes there is clearly a problem in the code, when the switcher detects 'switch-window-backwards' sets backwards to true but on the following lines (In the 'FIXME' section) is reset to false again.
IT should only be reset if its not true already.
I also patched it myself otherwise the switcher is really annoying to use

Revision history for this message
Collin Lefeber (cfebs) wrote :

Yup also a problem for me!

Does the patch simply check for shift or does it consider the full keybinding for the backwards setting?

Cody Garver (codygarver)
Changed in gala:
milestone: none → freya-0.3.1
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → fasheng (fasheng-xu)
Revision history for this message
Hernan Keena (hpk2987) wrote :

For what i can see the patch considers the keybinding, The 'detect shift workaround' is still there but in a way that doesnt break the 'switch-window-backwards' keybind.

Cody Garver (codygarver)
Changed in gala:
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in gala:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.