Use oslo util to determine network interface

Bug #1438941 reported by Matthew Van Dijk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Matthew Van Dijk

Bug Description

Discovered this while running tox on a mac.

The guest function get_ip_address assumes eth0 (as default, but no functions pass the arg).
This causes failures if eth0 is not the network interface used.

oslo_utils has netutils.get_my_ipv4() which determines the interface programmatically.
I propose we remove get_ip_address and use the oslo util instead.

Changed in trove:
assignee: nobody → Matthew Van Dijk (mvandijk)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169564

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/169564
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=9ae1e3776714e54bdf979cf0339285b304eec38d
Submitter: Jenkins
Branch: master

commit 9ae1e3776714e54bdf979cf0339285b304eec38d
Author: Matt Van Dijk <email address hidden>
Date: Tue Mar 31 19:26:22 2015 -0400

    Use oslo util to determine network interface

    Removes get_ip_address and use the oslo util instead.

    The guest function get_ip_address assumes eth0 (as default, but no
    functions pass the arg).
    This causes failures if eth0 is not the network interface used.
    oslo_utils has netutils.get_my_ipv4() which determines the interface
    programmatically.

    Change-Id: I6a9961df36662ccccaf46d5262b6b81306912333
    Closes-bug: #1438941

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
importance: Undecided → Low
milestone: none → kilo-rc1
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.