ISCSIDriver initialized connection uses a hard coded value

Bug #1438833 reported by Aviram Bar-Haim
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Aviram Bar-Haim

Bug Description

ISCSIDriver initialize connection is a duplicated function left in kilo to serve drivers that don't use the new targets model.
In Kilo there is a new parameter of iscsi_protocol, that is set to iscsi by default and can be changed to iser in order to enable RDMA.

In order support RDMA in drivers that still inherit from ISCSIDriver, driver_volume_type (https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#l1575 )
should be set to iscsi_protocol parameter value ('driver_volume_type' = self.configuration.safe_get('iscsi_protocol')) instead of a hard coded value (as in https://github.com/openstack/cinder/blob/326d165d9c7b27517ac349b30c5815f0bed171ce/cinder/volume/targets/iscsi.py#l284 ) until this function duplication will be solved.

Changed in cinder:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170178

Changed in cinder:
assignee: nobody → Aviram Bar-Haim (aviramb)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/170178
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=15b17071629a72e5e23340ba85fc0538a61541eb
Submitter: Jenkins
Branch: master

commit 15b17071629a72e5e23340ba85fc0538a61541eb
Author: Aviram Bar-Haim <email address hidden>
Date: Thu Apr 2 17:37:04 2015 +0300

    Fix ISCSIDriver initialized connection volume type

    ISCSIDriver initialize connection is a duplicated function
    left in kilo to serve drivers that don't use the new targets model.

    In Kilo there is a new parameter of iscsi_protocol, that is set to
    iscsi by default and can be changed to iser in order to enable RDMA.

    In order support RDMA in drivers that still inherit from ISCSIDriver,
    driver_volume_type should be set to iscsi_protocol parameter value
    instead of a hard coded value until this function duplication will be solved.

    Closes-Bug: #1438833

    Change-Id: If51ff933b75bf475c779d2599776f8a83acc08e5

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.