Creation of share server should fail early with VXLAN, GRE with NetApp cDOT driver

[Rushil Chugh]

Steps to reproduce:

1. Setup Neutron with VXLAN as the segmentation technology.
2. Setup Manila with a cDOT backend.
3. Create a share network using the VXLAN network.
4. Try creating a share with the share aforementioned share network.
5. Creation of share and share network succeeds and a VXLAN id is provided to the share. This is incorrect as NetApp only supports VLAN as a segmentation technology.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170606

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/171422

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170606
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b196f9b80385b94f67fd3d6772a4460bb2303914
Submitter: Jenkins
Branch: master

commit b196f9b80385b94f67fd3d6772a4460bb2303914
Author: Rushil Chugh <email address hidden>
Date: Tue Mar 31 17:17:45 2015 -0400

    Add segmentation ID checks for different segmentation types

    The segmentation approach used by the network plugin associated with a share
    server was not declared to the driver. This made it impossible for a driver
    to know whether a network used VLAN, GRE, VXLAN, or any other segmentation
    approach, and introduced the possibility of an incorrect segmentation
    approach to be applied to a share server.
    This patchset makes the network_type field available to the driver, and
    checks that segmentation id has valid values for different network_types.
    If the segmentation id has an incorrect value, it fails with a clean
    error message.

    Partial-Bug: 1438825

    Change-Id: I9f20a26e9c10d49ca3c82a46f49bdb5c65fd4a24

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/171422
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=63a66f99c385381790325da2c0324a3bbb7f71c3
Submitter: Jenkins
Branch: master

commit 63a66f99c385381790325da2c0324a3bbb7f71c3
Author: Rushil Chugh <email address hidden>
Date: Tue Mar 31 17:17:45 2015 -0400

    Prevent share server creation with unsupported network types with cDOT

    This patchset proposes to make NetApp Data ONTAP driver fail correctly
    on unsupported network types such as VXLAN and GRE. This patchset
    applies a correct filter to check for the segmentation technology
    used, and throws a clean error message if the segmentation
    technology is not supported by the NetApp cDOT Driver.

    Closes-bug: 1438825

    Change-Id: I2329322853b8f360b83118442d759f4ea3780579