ilo driver inspection requires extra parameters

[aeva black]

Initiating inspection should be done by changing the node state, eg, PUT {"target": "inspect"} /v1/nodes/NNN/states/provision, as per the spec:
http://specs.openstack.org/openstack/ironic-specs/specs/kilo/ironic-node-properties-discovery.html

However, the ilo driver requires that the driver_info['inspect_ports'] property have been set to specific values prior to initiating the state transition to inspection. When a user follows the documented methods to initiate inspection, the ilo driver will error. The user must then read the error to understand how this driver behaves differently, pass in a special driver_info parameter, and then try to inspect again.

validate requires additional "inspect_ports":
https://github.com/openstack/ironic/blob/a0fde7ec56c71f34f79244823e31d2aa69f5756e/ironic/drivers/modules/ilo/inspect.py#L288-L314

in-line documentation of what that means:
https://github.com/openstack/ironic/blob/a0fde7ec56c71f34f79244823e31d2aa69f5756e/ironic/drivers/modules/ilo/inspect.py#L196-L214

Apparently this was done as a work-around for the situation where some NICs are not connected to the network, and enrolling those will lead to random failures during deploy. See https://bugs.launchpad.net/ironic/+bug/1405131 for a description of that issue. I don't think it's appropriate to implement a driver-specific change in the REST API to work around a bug that affects every driver in Ironic.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169303

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169303
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=2c04ccff791f2e695f4130191be1892a961aa16d
Submitter: Jenkins
Branch: master

commit 2c04ccff791f2e695f4130191be1892a961aa16d
Author: Ramakrishnan G <email address hidden>
Date: Tue Mar 31 13:16:59 2015 +0000

    Remove inspect_ports from ilo inspection

    This commit removes the driver_info parameter
    'inspect_ports' which was required for ilo driver
    inspection. After this change, all the NICs detected
    by iLO will be enrolled as Ironic ports and operators
    are supposed to delete the Ironic ports for unused
    NICs manually (deploy may fail if all Ironic ports
    are enrolled due to bug 1405131).

    Closes-bug: 1438546
    Change-Id: I37eb1dda649d4d21681555339c9ece8a18216f95

[Wan-yen Hsu (wanyenhsu)]

Instead of removing inspect_ports , we can make inspect_ports default to inspect all NICs. This approach will not require admin to use inspect_ports but they have an option to use it to specify the exact ports to inspect. Some OpenStack installing tools do all bare-metal installation and configuration automatically by using a hardware description file provided by admin and it hides all the Ironic configuration details from users. Therefore, there might be issues to require manaully deletion of unused ports.