add_instance_fault_from_exc expects object but isn't always passed one

[Andrew Laski]

2015-03-30 15:02:58.287 28424 DEBUG oslo_messaging._drivers.amqp [-] UNIQUE_ID is 9c2e286750e7407cb78e273becca4ab0. _add_unique_id /usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqp.py:224
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/poll.py", line 115, in wait
    listener.cb(fileno)
  File "/opt/stack/nova/nova/utils.py", line 888, in wrapper
    return func(*args, **kwargs)
  File "/opt/stack/nova/nova/conductor/manager.py", line 688, in build_instances
    exc, request_spec)
  File "/opt/stack/nova/nova/conductor/manager.py", line 594, in _set_vm_state_and_notify
    ex, request_spec, self.db)
  File "/opt/stack/nova/nova/scheduler/utils.py", line 107, in set_vm_state_and_notify
    new_ref, ex, sys.exc_info())
  File "/opt/stack/nova/nova/compute/utils.py", line 87, in add_instance_fault_from_exc
    fault_obj.instance_uuid = instance.uuid
AttributeError: 'dict' object has no attribute 'uuid'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169014
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bfced2f5e21c4bdff1d0e978a0a3595e3597a6a5
Submitter: Jenkins
Branch: master

commit bfced2f5e21c4bdff1d0e978a0a3595e3597a6a5
Author: Andrew Laski <email address hidden>
Date: Mon Mar 30 13:20:43 2015 -0400

    Pass instance object to add_instance_fault_from_exc

    The add_instance_fault_from_exc method was recently changed to require
    that it is passed an instance object. When a scheduled build failed in
    conductor the utility method it was using to set the instance to error
    and report the fault was passing a db model to
    add_instance_fault_from_exc. This updates that method to properly pass
    an instance object.

    Change-Id: I3f0d0f5069c6b61a1450a626d92864076384c34d
    Closes-Bug: 1438315