VPNaaS: remove dependency on Neutron in UT

Bug #1438259 reported by Paul Michali
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Paul Michali

Bug Description

Some of the driver unit tests mock execute() from Neutron, which creates a (brittle) dependency (as seen by a recent breakage).

The dependency can be removed, but mocking higher up, from within the *Swan process _execute() method.

In addition, there are some unit tests that are not active, due to missing test base class.

Tags: vpnaas
Paul Michali (pcm)
Changed in neutron:
assignee: nobody → Paul Michali (pcm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-vpnaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169008

Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → High
milestone: none → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/169008
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=65a294eebca3297db2ca33846a6058d7d36a9869
Submitter: Jenkins
Branch: master

commit 65a294eebca3297db2ca33846a6058d7d36a9869
Author: Paul Michali <email address hidden>
Date: Mon Mar 30 15:05:34 2015 +0000

    VPNaaS Remove dependency on Neutron for unit test

    Instead of mocking the execute() method from Neutron, we'll mock
    higher up, at _execute() for the *Swan process. This will isolate
    the tests from Neutron.

    Found that some DVR tests were not activated (missing BaseTestCase
    inheritance), and cleaned up a few tests.

    Change-Id: Ia7655714088f53478d4286b8f61fca77688c1ecc
    Closes-Bug: #1438259

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.