VMware: retype fails with AttributeError: 'Volume' object has no attribute 'instance_uuid'

[Vipin Balachandran]

Volume retype fails with:

015-03-30 05:59:57.431 ERROR cinder.volume.manager [req-f224d0c3-7166-4a9c-a28e-0598c40dd303 None None] Volume cbbe424d-4952-4a8f-ae0f-07cb10c77ab4: driver error when trying to retype, falling back to generic mechanism.
2015-03-30 05:59:57.432 ERROR cinder.volume.manager [req-f224d0c3-7166-4a9c-a28e-0598c40dd303 None None] 'Volume' object has no attribute 'instance_uuid'
2015-03-30 05:59:57.432 TRACE cinder.volume.manager Traceback (most recent call last):
2015-03-30 05:59:57.432 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1637, in retype
2015-03-30 05:59:57.432 TRACE cinder.volume.manager host)
2015-03-30 05:59:57.432 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2015-03-30 05:59:57.432 TRACE cinder.volume.manager return f(*args, **kwargs)
2015-03-30 05:59:57.432 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/vmware/vmdk.py", line 1376, in retype
2015-03-30 05:59:57.432 TRACE cinder.volume.manager if self._in_use(volume):
2015-03-30 05:59:57.432 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/vmware/vmdk.py", line 1353, in _in_use
2015-03-30 05:59:57.432 TRACE cinder.volume.manager return volume['instance_uuid'] is not None
2015-03-30 05:59:57.432 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/oslo_db/sqlalchemy/models.py", line 54, in __getitem__
2015-03-30 05:59:57.432 TRACE cinder.volume.manager return getattr(self, key)
2015-03-30 05:59:57.432 TRACE cinder.volume.manager AttributeError: 'Volume' object has no attribute 'instance_uuid'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/168901

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168901
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cb658b5e0437d72b1929f7bcbed79795288f5d13
Submitter: Jenkins
Branch: master

commit cb658b5e0437d72b1929f7bcbed79795288f5d13
Author: Vipin Balachandran <email address hidden>
Date: Mon Mar 30 06:29:03 2015 -0700

    VMware: Fix instance_uuid access in volume retype

    Retype implementation still uses volume['instance_uuid'] to
    check in-use volumes. This patch replaces it with a check
    for non-empty volume['volume_attachment'] list.

    Change-Id: I268d30ed259a04f8bcf05fb0d45ba1d8e8332c34
    Closes-Bug: #1438185