OVN: lswitch for external ID's does not work

[Gary Kotton]

When configuring external ID's the plugin was doing this via the UUID of the network. This does not work as the OVN implementation makes use of internal checks to validate if the name is a UUID. If so it has a different code path.

 ['ovn-nbctl', 'lswitch-set-external-id', '0d159b40-7392-4433-8e86-c0d7b2afb615', 'neutron:network_name', 'X'] from (pid=23814) execute_rootwrap_daemon /opt/stack/neutron/neutron/agent/linux/utils.py:98
2015-03-29 03:22:06.098 DEBUG neutron.agent.linux.utils [req-3ad5f224-edc3-45c4-b0da-bc4df6fe151d demo e0ded9f5d6d64b88833d7e2dd06cad7d]
Command: [u'ovn-nbctl', u'lswitch-set-external-id', u'0d159b40-7392-4433-8e86-c0d7b2afb615', u'neutron:network_name', u'X']
Exit code: 0
Stdin:
Stdout:
Stderr: 2015-03-29T10:22:06Z|00001|ovn_nbctl|WARN|lswitch not found for UUID: '0d159b40-7392-4433-8e86-c0d7b2afb615'
 from (pid=23814) execute /opt/stack/neutron/neutron/agent/linux/utils.py:132
2015-03-29 03:22:06.099

[Gary Kotton (garyk)]

This would result in networks not being deleted on the OVN

[Gary Kotton (garyk)]

Fixed in https://review.openstack.org/168687

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168687
Committed: https://git.openstack.org/cgit/stackforge/networking-ovn/commit/?id=71632c9ba2ac08ba8cf75151f3a3cbfd7bca0c18
Submitter: Jenkins
Branch: master

commit 71632c9ba2ac08ba8cf75151f3a3cbfd7bca0c18
Author: Gary Kotton <email address hidden>
Date: Sun Mar 29 04:07:42 2015 -0700

    Correct usage of the external-id for networks

    The OVN utility checks if the name is a UUID. If so then it will have
    a different code path and then external-id will not be matched.

    If it is a match then it will update an entry belonging to another network.

    Change-Id: Ida4d1407f065b7d6f9fe3f14e94b368014b44e8d
    Closes-bug: #1437808