Fuel-qa project cannot pass Flake8 checks

[Yaroslav Lobankov]

$ ./run_tests.sh
+ flake8 --ignore=H302,H802 --show-source ./
./fuelweb_test/helpers/checkers.py:922:5: E265 block comment should start with '# '
    #check stat on collector side
    ^
./fuelweb_test/helpers/checkers.py:929:45: E251 unexpected spaces around keyword / parameter equals
                                      query=
                                            ^
./fuelweb_test/helpers/security.py:115:37: E128 continuation line under-indented for visual indent
                                    ' on {2} (node-{3}) node. Check {4}.old'
                                    ^
./fuelweb_test/helpers/security.py:116:37: E128 continuation line under-indented for visual indent
                                    ' and {4}.dump files on the node for de'
                                    ^
./fuelweb_test/helpers/security.py:117:37: E128 continuation line under-indented for visual indent
                                    'tails').format(port, protocol,
                                    ^
./fuelweb_test/models/environment.py:289:9: E265 block comment should start with '# '
        #Restart statsenderd in order to apply new settings (Collector address)
        ^
./fuelweb_test/tests/test_ceph.py:274:9: E265 block comment should start with '# '
        #Check resources addition
        ^
./fuelweb_test/tests/test_ceph.py:275:9: E265 block comment should start with '# '
        #create instance
        ^
./fuelweb_test/tests/test_ceph.py:279:9: E265 block comment should start with '# '
        #create flavor
        ^
./fuelweb_test/tests/test_ceph.py:282:9: E265 block comment should start with '# '
        #create volume
        ^
./fuelweb_test/tests/test_ceph.py:285:9: E265 block comment should start with '# '
        #create image
        ^
./fuelweb_test/tests/test_ceph.py:302:9: E265 block comment should start with '# '
        #create tenant and user
        ^
./fuelweb_test/tests/test_ceph.py:317:9: E265 block comment should start with '# '
        #Check resources modification
        ^
./fuelweb_test/tests/test_ceph.py:318:9: E265 block comment should start with '# '
        #suspend instance
        ^
./fuelweb_test/tests/test_ceph.py:320:9: E265 block comment should start with '# '
        #edit volume
        ^
./fuelweb_test/tests/test_ceph.py:322:9: E265 block comment should start with '# '
        #edit image
        ^
./fuelweb_test/tests/test_ceph.py:324:9: E265 block comment should start with '# '
        #edit user
        ^
./fuelweb_test/tests/test_ceph.py:326:9: E265 block comment should start with '# '
        #edit tenant
        ^
./fuelweb_test/tests/test_ceph.py:336:9: E265 block comment should start with '# '
        #Check resources deletion
        ^
./fuelweb_test/tests/test_ceph.py:337:9: E265 block comment should start with '# '
        #delete instance
        ^
./fuelweb_test/tests/test_ceph.py:339:9: E265 block comment should start with '# '
        #delete flavor
        ^
./fuelweb_test/tests/test_ceph.py:341:9: E265 block comment should start with '# '
        #delete volume
        ^
./fuelweb_test/tests/test_ceph.py:343:9: E265 block comment should start with '# '
        #delete image
        ^
./fuelweb_test/tests/test_ceph.py:345:9: E265 block comment should start with '# '
        #delete tenant
        ^
./fuelweb_test/tests/test_ceph.py:347:9: E265 block comment should start with '# '
        #delete user
        ^
./fuelweb_test/models/fuel_web_client.py:420:17: E112 expected an indented block
                # Use defaults from Nailgun if MIRROR_UBUNTU is not set
                ^
./fuelweb_test/tests/test_upgrade.py:36:9: E265 block comment should start with '# '
        #the archive contains several versions of the kernel
        ^
./fuelweb_test/tests/test_upgrade.py:37:9: E265 block comment should start with '# '
        #regular expression will pick the newer one
        ^
./fuelweb_test/tests/test_upgrade.py:38:9: E265 block comment should start with '# '
        #that is actually gets installed
        ^
./fuelweb_test/tests/test_upgrade.py:96:52: E251 unexpected spaces around keyword / parameter equals
                            'upgrade.sh', password=
                                                   ^
./fuelweb_test/tests/test_upgrade.py:164:52: E251 unexpected spaces around keyword / parameter equals
                            'upgrade.sh', password=
                                                   ^
./fuelweb_test/tests/test_upgrade.py:220:52: E251 unexpected spaces around keyword / parameter equals
                            'upgrade.sh', password=
                                                   ^
./fuelweb_test/tests/test_upgrade.py:313:52: E251 unexpected spaces around keyword / parameter equals
                            'upgrade.sh', password=
                                                   ^
./fuelweb_test/tests/test_upgrade.py:400:38: E251 unexpected spaces around keyword / parameter equals
                            password=
                                     ^
./fuelweb_test/tests/test_upgrade.py:461:9: E265 block comment should start with '# '
        #we expect 255 exit code here because upgrade failed
        ^
./fuelweb_test/tests/test_upgrade.py:466:38: E251 unexpected spaces around keyword / parameter equals
                            password=
                                     ^
./fuelweb_test/tests/plugins/plugin_example/test_fuel_plugin_example.py:265:10: E111 indentation is not a multiple of four
         # check if service ran on controller
         ^
./fuelweb_test/tests/plugins/plugin_example/test_fuel_plugin_example.py:265:10: E113 unexpected indentation
         # check if service ran on controller
         ^
./fuelweb_test/tests/tests_strength/test_image_based.py:64:9: E265 block comment should start with '# '
        #wait nodes go to reboot
        ^
./fuelweb_test/tests/tests_strength/test_image_based.py:66:9: E265 block comment should start with '# '
        #wait for nodes to appear after bootstrap
        ^
./fuelweb_test/tests/tests_os_patching/test_os_patching.py:116:74: E251 unexpected spaces around keyword / parameter equals
        checkers.run_script(node_ssh, '/var/tmp', 'upgrade.sh', password=
                                                                         ^
./fuelweb_test/tests/tests_os_patching/test_os_patching.py:285:5: E265 block comment should start with '# '
    #@test(depends_on=[deploy_and_patch])
    ^
./fuelweb_test/tests/tests_strength/test_failover_base.py:337:13: E128 continuation line under-indented for visual indent
            ("netstat -nap | grep {0} | grep :5673".
            ^

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167990
Committed: https://git.openstack.org/cgit/stackforge/fuel-qa/commit/?id=5334ad0b6c0c60b61f61eb7731308c2df197f52e
Submitter: Jenkins
Branch: master

commit 5334ad0b6c0c60b61f61eb7731308c2df197f52e
Author: Yaroslav Lobankov <email address hidden>
Date: Thu Mar 26 16:31:32 2015 +0300

    Editing code for passing Flake8 checks

    Now if we run script run_tests.sh, we will not have any Flake8 errors

    Closes-Bug: #1437360

    Change-Id: I3fb54da5a160f848957f602c9cbdc19367b7f543

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176795

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176795
Committed: https://git.openstack.org/cgit/stackforge/fuel-qa/commit/?id=0512eee73f2c977e99a691832b7bb8d494957e62
Submitter: Jenkins
Branch: master

commit 0512eee73f2c977e99a691832b7bb8d494957e62
Author: Yaroslav Lobankov <email address hidden>
Date: Thu Apr 23 18:01:28 2015 +0300

    Editing code for passing Flake8 checks - part 2

    Now if we run script run_tests.sh, we will not have any Flake8 errors

    Change-Id: Ieb8a9c8df842b735e923d3d71c48a200d79c3e4e
    Closes-Bug: #1437360

[Anastasia Kuznetsova (akuznetsova)]

Verified