Some manila migrations have SQL code while manila uses ORM

Bug #1437278 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Valeriy Ponomaryov

Bug Description

Manila uses ORM sqlalchemy as abstraction between DB layer and python entities.

Some DB migrations are performed using sqlalchemy and some don't. It causes problems with support of DB backends that are not tested on periodic approach, such as PostreSQL.

We need to port our migrations that use direct SQL code to analog from ORM because SQL code for several backends can differ.

Tags: db
tags: added: db
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168983

Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
status: New → In Progress
Changed in manila:
importance: Undecided → Medium
milestone: none → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/168983
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bf7fc87067f0eef50e30932b14a249f7632c0733
Submitter: Jenkins
Branch: master

commit bf7fc87067f0eef50e30932b14a249f7632c0733
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Mar 30 19:00:44 2015 +0300

    Replace SQL code for ORM analog in DB migration scripts

    Replace explicit usage of SQL code with appropriate analog of ORM.
    It allows to keep abstraction between DB and python clear without
    potential incompatibilities due to differencies in SQL dialects.

    Change-Id: Ied97264cafcec0bcebd4c3ddc7b29185825c56a6
    Closes-Bug: #1437278

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.