SMBFS: missing volume provider location

Bug #1437271 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Lucian Petrut

Bug Description

In case of cloning volumes or creating volumes from snapshots, the volume provider location is not set, making the volumes unusable. This also leads to disk image leaks, because the delete volume operation will pass without deleting the disk image if the provider location is not present.

The SMB driver wraps base RemoteFS methods in order to set locks. The issue is that it does not return the wrapped method return value, which signals volume updates, in this case the provider location.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168305

Changed in cinder:
assignee: nobody → Petrut Lucian (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/168305
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6b78f47bb0e51323a9b2b4df72abf11cce60e396
Submitter: Jenkins
Branch: master

commit 6b78f47bb0e51323a9b2b4df72abf11cce60e396
Author: Lucian Petrut <email address hidden>
Date: Fri Mar 27 13:42:22 2015 +0200

    SMBFS: Fix missing volume provider location

    In case of cloning volumes or creating volumes from snapshots, the
    volume provider location is not set, making the volumes unusable.

    This also leads to disk image leaks, because the delete volume
    operation will pass without deleting the disk image if the provider
    location is not present.

    The SMB driver wraps base RemoteFS methods in order to set locks.
    The issue is that it does not return the wrapped method return
    value, which signals volume updates, in this case the provider
    location.

    Change-Id: Id7435676052885d301a48fa5ac224071e18ecf5b
    Closes-Bug: #1437271

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.