OpenStack DBaaS (Trove)

py27 tests fail for get_flavors

Bug #1437179 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Peter Stachowski
OpenStack DBaaS (Trove) 4.0.0 "liberty"
Kilo
Fix Committed
Medium
Tony Breeds

Bug Description

experienced few time that py27 test sometimes fail for get_flavors.

Failure message is a long one, putting that to http://paste.openstack.org/show/196997/

Just got to see the same on one of patchset gate results.

http://logs.openstack.org/60/164460/9/check/gate-trove-python27/f677e28/console.html

Peter Stachowski (peterstac)
Changed in trove:
assignee: nobody → Peter Stachowski (peterstac)
Revision history for this message
Peter Stachowski (peterstac) wrote :

I've run into this several times as well. This seems to be caused by the fact that the results can come back in a different order. The json needs to be sorted first before being compared.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223200

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/223200
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=7a9e02a1fa50fdccf0d06e9706a4bec25f127c5c
Submitter: Jenkins
Branch: master

commit 7a9e02a1fa50fdccf0d06e9706a4bec25f127c5c
Author: Peter Stachowski <email address hidden>
Date: Mon Sep 14 11:29:12 2015 -0400

    Fix get_flavors test by sorting json output

    The get_flavors unit test sometimes fails as the list can
    come back in a different order. This causes the json comparison
    to inacurately claim that the content is different. Since
    we don't care what order the json data is stored, this
    comparison is now done on a sorted data set.

    Closes-Bug: #1437179
    Change-Id: I92eaa1c98f5a58ce124210f2b6a2136dfc573a29

Changed in trove:
status: In Progress → Fix Committed
Nikhil Manchanda (slicknik)
Changed in trove:
milestone: none → liberty-rc1
importance: Undecided → High
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-rc1 → 4.0.0
Amrith Kumar (amrith)
tags: added: low-hanging-fruit
Revision history for this message
Peter Stachowski (peterstac) wrote :

This has been fixed and released - not sure why it's being tagged still ...

Revision history for this message
Peter Stachowski (peterstac) wrote :

ah, the cherry-pick back to kilo, right

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/303223

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (stable/kilo)

Reviewed: https://review.openstack.org/303223
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=9f5de06a2d9071ecb8c797fcb772f54bc62f5fa4
Submitter: Jenkins
Branch: stable/kilo

commit 9f5de06a2d9071ecb8c797fcb772f54bc62f5fa4
Author: Peter Stachowski <email address hidden>
Date: Mon Sep 14 11:29:12 2015 -0400

    Fix get_flavors test by sorting json output

    The get_flavors unit test sometimes fails as the list can
    come back in a different order. This causes the json comparison
    to inacurately claim that the content is different. Since
    we don't care what order the json data is stored, this
    comparison is now done on a sorted data set.

    Closes-Bug: #1437179
    Change-Id: I92eaa1c98f5a58ce124210f2b6a2136dfc573a29
    (cherry picked from commit 7a9e02a1fa50fdccf0d06e9706a4bec25f127c5c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.