PciDeviceStats not compared properly

Bug #1436986 reported by Attila Fazekas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Moshe Levi

Bug Description

https://github.com/openstack/nova/blob/5b77c108f14f2bcd42fecfcd060331e57a2e07dd/nova/compute/resource_tracker.py#L554 is always true, since the nova.pci.stats.PciDeviceStats is different object even if it has an equivalent content.

Please compare the resources properly and send updated resource info ONLY when it is REALLY needed.

Moshe Levi (moshele)
Changed in nova:
assignee: nobody → Moshe Levi (moshele)
tags: added: pci-passthrough
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168317

Changed in nova:
status: New → In Progress
Changed in nova:
importance: Undecided → Low
Changed in nova:
assignee: Moshe Levi (moshele) → Roey Chen (roeyc)
Moshe Levi (moshele)
Changed in nova:
assignee: Roey Chen (roeyc) → Moshe Levi (moshele)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/168317
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0efc217ba00f49e4d51bafed54d483007a4d51c5
Submitter: Jenkins
Branch: master

commit 0efc217ba00f49e4d51bafed54d483007a4d51c5
Author: Moshe Levi <email address hidden>
Date: Fri Mar 27 14:19:24 2015 +0300

    Add equality operators to PciDeviceStats and PciDevice objects

    resources['pci_device_pools'] value is now PciDeviceStats object
    therefore when comparing this resource it is need equality operators
    to compare the inner content.
    the PciDeviceStats itself contain PciDevice objects, therefore
    equality operators need here as well.

    Closes-Bug: #1436986

    Change-Id: Ib6f051dd65ad6960bba18052b49a9a678d3b3ae0

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.