Attr "is_public" can not be set for share using API "manage"

[Valeriy Ponomaryov]

Existing API "manage" allows us to manage existing share, and we can provide following attrs:

$ manila help manage
usage: manila manage [--name <name>] [--description <description>]
                     [--share_type <share_type>]
                     [--driver_options [<key=value> [<key=value> ...]]]
                     <service_host> <protocol> <export_path>

Manage share not handled by Manila.

Positional arguments:
  <service_host> manage-share service host: some.host@driver[#pool]
  <protocol> Protocol of the share to manage, such as NFS or CIFS.
  <export_path> Share export path.

Optional arguments:
  --name <name> Optional share name. (Default=None)
  --description <description>
                        Optional share description. (Default=None)
  --share_type <share_type>, --share-type <share_type>
                        Optional share type assigned to share. (Default=None)
  --driver_options [<key=value> [<key=value> ...]], --driver-options [<key=value> [<key=value> ...]]
                        Driver option key=value pairs (Optional,
                        Default=None).

But we can not set explicitly its visibility (key '--public') that we can do using API "create".

$ manila help create
...

Positional arguments:
...

Optional arguments:
...
  --public Level of visibility for share. Defines whether other
                        tenants are able to see it or not.

[Ben Swartzlander (bswartz)]

Workaround for this bug: do "manila update" after "manila manage"

[NidhiMittalHada (nidhimittal19)]

I am working on this task.
Approach is to add is_public as an additional attr in existing manage command.
We will be able to provide is_public true/False in manila manage command after this change.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/223458

[Ben Swartzlander (bswartz)]

I'm not convinced this is a bug. Why is it not acceptable to do 2 operations -- manage followed by update.

[Ben Swartzlander (bswartz)]

Okay I'll accept this as a bug to be fixed. Targeting for M-1.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/230967

[Valeriy Ponomaryov (vponomaryov)]

FIx "proposed", not "committed" yet.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238850

[OpenStack Infra (hudson-openstack)]

Change abandoned by NidhiMittalHada (<email address hidden>) on branch: master
Review: https://review.openstack.org/223458
Reason: Please ignore this change id

[OpenStack Infra (hudson-openstack)]

Change abandoned by NidhiMittalHada (<email address hidden>) on branch: master
Review: https://review.openstack.org/230967
Reason: Commit created for testing please abandon

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238850
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=2315e563b7540888c9ebf18e7c98b6bed7ca1255
Submitter: Jenkins
Branch: master

commit 2315e563b7540888c9ebf18e7c98b6bed7ca1255
Author: nidhimittalhada <email address hidden>
Date: Wed Dec 2 16:47:15 2015 +0530

    Allow to set share visibility using "manage" API

    This fix allows manila manage command to explicitly
    set visibility (key '--public') similar to using API
    "create".

    Change-Id: I8725719b8c7ff5557fa20ebbb5314f3e770ffcc0
    Closes-Bug: #1436865

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-manilaclient 1.6.0 release.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.