cpu pinning request was ignored

Bug #1436823 reported by Alex Xu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Alex Xu

Bug Description

When boot instance with dedicated cpu_policy, the cpu_pinning field of InstanceNUMATopology is '{}'.
But the function 'instance_topology_from_instance' just missed that fields when convert instance numa topology dict back to object:

https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1150.

That leads to the cpu_pinning just ignored.

Alex Xu (xuhj)
Changed in nova:
assignee: nobody → Alex Xu (xuhj)
milestone: none → kilo-rc1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167972

Changed in nova:
status: New → In Progress
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Alex, why is this a High Importance bug?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/167972
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=58256b6a39a522f33dfda929955ea46b7cd3331a
Submitter: Jenkins
Branch: master

commit 58256b6a39a522f33dfda929955ea46b7cd3331a
Author: He Jie Xu <email address hidden>
Date: Thu Mar 26 20:31:50 2015 +0800

    Fix missing the cpu_pinning request

    When boot instance with dedicated cpu_policy, the cpu_pinning field
    of InstanceNUMATopology is '{}'. But the function
    'instance_topology_from_instance' just missed that fields when convert
    instance numa topology dict back to object. That leads to the cpu_pinning
    just ignored. This patch fixed that.

    Change-Id: I8711cdc59c7455b3c8f94c68ab7f38d96ce168c4
    Closes-Bug: #1436823

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Alex Xu (xuhj) wrote :

dims, honestly say I didn't very clear what rule of set bug importance, I just think this is cool feature, but just be ignored.

Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.