puppet element: file path can be parsed

[Haiwei Xu]

Currently when using software-config template example for puppet to create a stack, got this error:

Mar 26 11:46:44 puppet-inst os-collect-config: [2015-03-26 11:46:44,592] (heat-config) [INFO] {"deploy_stdout": "\u001b[mNotice: Compiled catalog for puppet-inst.novalocal in environment production in 0.06 seconds\u001b[0m\n", "deploy_stderr": "\u001b[1;31mError: Parameter path failed on File[output_result]: File paths must be fully qualified, not '$::heat_outputs_path.result' at /var/lib/heat-config/heat-config-puppet/ced7d071-a5a0-4b96-ae4e-a06045850cbc.pp:13\nWrapped exception:\nFile paths must be fully qualified, not '$::heat_outputs_path.result'\u001b[0m\n", "deploy_status_code": 1}

the template file is /heat-templates/hot/software-config/example-templates/config-scripts/example-puppet-manifest.pp
  1 file { 'barfile':
  2 ensure => file,
  3 mode => '0644',
  4 path => '/tmp/$::bar',
  5 content => '$::foo',
  6 }
  7
  8 file { 'output_result':
  9 ensure => file,
 10 path => '$::heat_outputs_path.result',
 11 mode => '0644',
 12 content => 'The file /tmp/$::bar contains $::foo',
 13 }

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167961

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167961
Committed: https://git.openstack.org/cgit/openstack/heat-templates/commit/?id=2fca7ef1e7c3fdfe776f897e23161d250625a6ad
Submitter: Jenkins
Branch: master

commit 2fca7ef1e7c3fdfe776f897e23161d250625a6ad
Author: Haiwei Xu <email address hidden>
Date: Fri Mar 27 10:16:10 2015 +0900

    Fix puppet template "file patch parse error"

    The parameter in software-config puppet template
    can't be parsed by using "'", should change it to '"'.

    Change-Id: I83e49ae538a04684ab836f7848e8861b20975be3
    Closes-Bug: #1436817