cinder-volume raises TypeError when volume_service_inithost_offload=true

[Ian Denhardt]

This happens on startup when there are volumes in the deleting state.

Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/eventlet/greenpool.py", line 80, in _spawn_n_impl
func(*args, **kwargs)
TypeError: 'bool' object is not callable

The problem is fairly trivial -- in cinder.volume.manager we're calling the function to be deferred and passing the result, rather than passing the function and it's arguments. I'm preparing patch for review now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167858
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=748ddf3ec1caf1ad78cf58f3099618a62cb8eb56
Submitter: Jenkins
Branch: master

commit 748ddf3ec1caf1ad78cf58f3099618a62cb8eb56
Author: Ian Denhardt <email address hidden>
Date: Wed Mar 25 21:47:47 2015 -0400

    Fix incorrect invocation of _add_to_threadpool

    _add_to_threadpool expects to be passed the function and which is to be
    run in an alternate thread, and the function's arguments. Instead, the
    function (self.delete_volume) was being invoked directly, and it's
    result passed to _add_to_threadpool. This results in a TypeError being
    raised (the result is a bool, which is not callable), but more
    importantly, it defeats the purpose of the statement - to offload the
    invocation of delete_volume to another thread.

    Change-Id: I524156cbffe0f6f5a2da902c6a62417d1ec425b9
    Closes-Bug: #1436624