Linux SMBFS: extra_specs lazy load error

Bug #1436418 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Lucian Petrut

Bug Description

The Linux SMBFS driver uses volume extra specs in order to determine the according image format when creating new volumes. Accessing the extra_specs attribute can raise the following error as this attribute is lazy loaded:

DetachedInstanceError: Parent instance <VolumeTypes at 0x7f692ce12850> is not bound to a Session; lazy load operation of attribute 'extra_specs' cannot proceed

This can be avoided by simply eager loading the extra specs.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167670

Changed in cinder:
assignee: nobody → Petrut Lucian (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/167670
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=19f6b7703663e12836fd6805e8c20b5507ede098
Submitter: Jenkins
Branch: master

commit 19f6b7703663e12836fd6805e8c20b5507ede098
Author: Lucian Petrut <email address hidden>
Date: Wed Mar 25 18:01:02 2015 +0200

    Eager load volume extra specs

    The Linux SMBFS driver uses volume extra specs in order to determine
    the according image format when creating new volumes.

    Accessing the extra_specs attribute can raise DetachedInstanceError
    as this attribute is lazy loaded and the session might close by the
    time this attribute is accessed.

    This can be avoided by simply eager loading the volume extra specs.

    Change-Id: Iffdb160a4a968067261aa90638832782caed5ed0
    Closes-Bug: #1436418

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.