Use node UUID in logs instead of node ID (which is internal)

[Zhenguo Niu]

we usually log node_id as a node when attempting to lock it:
"Attempting to reserve node 1"

but I can't get any information about '1' using node-list and node-show as below, so this will confuse users
when debuging with the log message.

(venv)root@zhenguo-MacBookPro:~/myenv/python-ironicclient# ironic node-list
+--------------------------------------+------+---------------+-------------+--------------------+-------------+
| UUID | Name | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+------+---------------+-------------+--------------------+-------------+
| 87f03e9f-6016-49dd-b376-5d735c626261 | | None | None | None | True |
| 80a86455-8c12-4e83-bd25-9ab3770c336e | | None | None | None | True |
| fbd5903e-bcba-41ff-af13-f5e6e252afcd | | None | None | None | False |
| 84147fb7-90ee-4912-b398-fc247067c040 | | None | None | None | True |
| 23aa74b4-5ac7-4708-b65a-a89ea7139e1b | | None | None | None | True |
+--------------------------------------+------+---------------+-------------+--------------------+-------------+

(venv)root@zhenguo-MacBookPro:~/myenv/python-ironicclient# ironic node-show 23aa74b4-5ac7-4708-b65a-a89ea7139e1b
+------------------------+----------------------------------------------------------------------+
| Property | Value |
+------------------------+----------------------------------------------------------------------+
| target_power_state | None |
| extra | {} |
| last_error | During sync_power_state, max retries exceeded for node |
| | 23aa74b4-5ac7-4708-b65a-a89ea7139e1b, node state None does not match |
| | expected state 'None'. Updating DB state to 'None' Switching node to |
| | maintenance mode. |
| updated_at | 2015-03-24T08:15:41+00:00 |
| maintenance_reason | During sync_power_state, max retries exceeded for node |
| | 23aa74b4-5ac7-4708-b65a-a89ea7139e1b, node state None does not match |
| | expected state 'None'. Updating DB state to 'None' Switching node to |
| | maintenance mode. |
| provision_state | None |
| uuid | 23aa74b4-5ac7-4708-b65a-a89ea7139e1b |
| console_enabled | False |
| target_provision_state | None |
| maintenance | True |
| inspection_started_at | |
| inspection_finished_at | |
| power_state | None |
| driver | pxe_ipmitool |
| reservation | None |
| properties | {} |
| instance_uuid | None |
| name | |
| driver_info | {u'ipmi_address': u'172.28.2.133', u'ipmi_username': u'root', |
| | u'ipmi_password': u'******'} |
| created_at | 2015-03-23T02:02:40+00:00 |
| driver_internal_info | |
| chassis_uuid | |
| instance_info | {} |
+------------------------+----------------------------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167623

[Dmitry Tantsur (divius)]

I've updated the report to reflect the fact that we don't want to expose node ID to users.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167627

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167623
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a0d30dca3442628f79b9dfec60c6564e6dfb8d0b
Submitter: Jenkins
Branch: master

commit a0d30dca3442628f79b9dfec60c6564e6dfb8d0b
Author: Zhenguo Niu <email address hidden>
Date: Wed Mar 25 22:42:44 2015 +0800

    Use node UUID in logs instead of node ID

    currently we use node ID in logs which is internal, so
    change to use UUID instead

    Change-Id: I6fc7f73ecc8d15c7b42c1715878ec0231eddbd03
    Partial-Bug: #1436366

[Zhenguo Niu (niu-zglinux)]

manually set status to 'Fix Commited', if you find more logs print node uuid, please correct me.