Fuel menu not updating all NTP servers in ntp.conf

[Aviram Bar-Haim]

after changing the first NTP line in fuel menu to ntp.org and deleting the rest of the lines we've got in /etc/ntp/ntp.conf:
server ntp.org iburst
server 1.pool.ntp.org iburst
server 2.pool.ntp.org iburst

This causes the installation to fail on ntp request since pool.ntp.org is not accessible from the setup (but ntp.org is accessible):
[root@fuel astute]# ntpdate -q -u pool.ntp.org
server 212.199.182.150, stratum 0, offset 0.000000, delay 0.00000
25 Mar 12:35:59 ntpdate[31020]: no server suitable for synchronization found
[root@fuel astute]# ntpdate -q -u 0.pool.ntp.org
server 212.199.182.150, stratum 0, offset 0.000000, delay 0.00000
25 Mar 12:36:05 ntpdate[31033]: no server suitable for synchronization found
[root@fuel astute]# ntpdate -q -u ntp.org
server 149.20.68.16, stratum 0, offset 0.000000, delay 0.00000
server 128.4.24.98, stratum 3, offset 0.004307, delay 0.17555
25 Mar 12:36:14 ntpdate[31038]: adjust time server 128.4.24.98 offset 0.004307 sec

When deleting x.pool.ntp.org servers from ntp.conf and restarting server and agents ntpd, ntpdate -u 10.20.0.2 worked again.
tcpdumps attached, before and after changing ntp.conf lines of fuel master

[root@fuel astute]# cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - experimental
  production: "docker"
  release: "6.1"
  api: "1.0"
  build_number: "133"
  build_id: "2015-03-24_05-58-19"
  nailgun_sha: "799cb09d8f6584283f2d2bc55dc50925e23fb4b2"
  python-fuelclient_sha: "3624051242c83fdbdd1df9a0e466797c06b75043"
  astute_sha: "631f96d5a09cc48bfbddcbf056b946c8a80438f0"
  fuellib_sha: "a530233a110856e1ef0e97d1aec4ed3e0aeaa880"
  ostf_sha: "a4cf5f218c6aea98105b10c97a4aed8115c15867"
  fuelmain_sha: "d32775630f42a12e54faaaa74d6bc8e47b997d48"

[Matthew Mosesohn (raytrac3r)]

Are you saying we should modify the default servers and that will fix the problem?

[Matthew Mosesohn (raytrac3r)]

After discussing with Stanislaw, it seems we need to make the following changes:
1 - Allow user to specify one, two, or three NTP servers in NTP configuration in Fuel Menu and not provide the default values when the user chooses to remove one.
2 - Adjust Puppet logic to pass only the specified servers. If you remove NTP2 and NTP3 from astute.yaml, you get the following:
server 0.pool.ntp.org iburst
server undef iburst
server undef iburst

As a short term workaround, I believe you can just specify ntp.org 3 times.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/171141

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/171141
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=622dea476f6f61afd1a4184c088973eca893cd84
Submitter: Jenkins
Branch: master

commit 622dea476f6f61afd1a4184c088973eca893cd84
Author: Matthew Mosesohn <email address hidden>
Date: Tue Apr 7 14:35:46 2015 +0300

    Avoid writing empty NTP servers to ntp.conf

    Added delete function to NTP servers for
    Fuel Master host deployment

    Change-Id: Ieaf40b9cff5a51cda1404db14e6cc895ffa90648
    Closes-Bug: #1436318

[Alexander Nevenchannyy (anevenchannyy)]

Verified on MOS 6.1 ISO #473
Steps to Verify:

1. In Fuel settings: 0.pool.ntp.org
2. At node:
root@node-1:~# grep server /etc/ntp.conf
server 0.pool.ntp.org iburst minpoll 3