[enhancement] mir/events/event_builders.h should be explicitly supported

[Alan Griffiths]

The mir/events/event_builders.h header provides definitions and features for building events that are useful for downstream test harnesses.

As such there should be acceptance tests for this functionality.

[Daniel van Vugt (vanvugt)]

... or replaced with something else that is explicityly supported.

The current format is to export C++ functions from libmirclient. It would be more consistent and portable if they were C functions like the rest of libmirclient.

[Alan Griffiths (alan-griffiths)]

The current condition is the result of a trade-off between inelegance of having these (and the other "MIR_CLIENT_DETAIL" functions) exported from libmirclient vs the cost of introducing another libmirclientdetail (say) library to contain everything that isn't just supporting the client API.

Suggesting making them C functions like the client API ignores the principle that not part of the client API.

As we get more and more "MIR_CLIENT_DETAIL" functions the argument for another library gets stronger.

[Daniel van Vugt (vanvugt)]

I'm still thinking some nice clean public C functions would be better.

It's quite conceivable that toolkits in future might want to use such functions to synthesise events for their own testing purposes.

[Michał Sawicz (saviq)]

Syncing task from Mir.