[system tests] Incorrect list creation in configure_second_admin_firewall method

Bug #1436255 reported by Dmitry Tyzhnenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Dmitry Tyzhnenko

Bug Description

Tests in thread_7 group was filied with traceback:

ERROR: Create environment and set up master node
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_7/fuelweb_test/helpers/decorators.py", line 66, in wrapper
    return func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_7/fuelweb_test/tests/base_test_case.py", line 60, in setup_master
    self.env.setup_environment()
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_7/fuelweb_test/models/environment.py", line 283, in setup_environment
    self.describe_second_admin_interface()
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_7/fuelweb_test/__init__.py", line 48, in wrapped
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_7/fuelweb_test/models/environment.py", line 507, in describe_second_admin_interface
    second_admin_netmask)
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_7/fuelweb_test/__init__.py", line 48, in wrapped
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_7/fuelweb_test/helpers/multiple_networks_hacks.py", line 71, in configure_second_admin_firewall
    ('-t nat -I POSTROUTING -s {0}/{1} -o eth+ -m comment --comment '
TypeError: 'str' object is not callable

In configure_second_admin_firewall method we missed comma when creating iptables rules

Tags: system-tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167546

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/167546
Committed: https://git.openstack.org/cgit/stackforge/fuel-qa/commit/?id=31548af41fecb3002c337e112a5770e3f624745d
Submitter: Jenkins
Branch: master

commit 31548af41fecb3002c337e112a5770e3f624745d
Author: Dmitry Tyzhnenko <email address hidden>
Date: Wed Mar 25 12:23:55 2015 +0200

    Add missed comma in multiple_networks_hacks.py

    Change-Id: I346ee25af0bc5ba1e6ad6f368b4e9857e71d2b6b
    Closes-bug: #1436255

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Dmitry Tyzhnenko (dtyzhnenko) wrote :

Verified on CI - http://jenkins-product.srt.mirantis.net:8080/view/6.1_swarm/job/6.1.system_test.ubuntu.thread_7/79/console

ISO version

{
    u'build_id': u'2015-03-25_21-15-27',
    u'ostf_sha': u'a4cf5f218c6aea98105b10c97a4aed8115c15867',
    u'build_number': u'229',
    u'auth_required': True,
    u'nailgun_sha': u'64a3d380cefde4f341cd39be350c4c9f78b59b7d',
    u'production': u'docker',
    u'api': u'1.0',
    u'python-fuelclient_sha': u'e5e8389d8d481561a4d7107a99daae07c6ec5177',
    u'astute_sha': u'631f96d5a09cc48bfbddcbf056b946c8a80438f0',
    u'fuelmain_sha': u'320b5f46fc1b2798f9e86ed7df51d3bda1686c10',
    u'feature_groups': [u'mirantis'],
    u'release': u'6.1',
    u'release_versions': {u'2014.2-6.1': {u'VERSION': {
        u'build_id': u'2015-03-25_21-15-27',
        u'ostf_sha': u'a4cf5f218c6aea98105b10c97a4aed8115c15867',
        u'build_number': u'229',
        u'api': u'1.0',
        u'nailgun_sha': u'64a3d380cefde4f341cd39be350c4c9f78b59b7d',
        u'production': u'docker',
        u'python-fuelclient_sha': u'e5e8389d8d481561a4d7107a99daae07c6ec5177',
        u'astute_sha': u'631f96d5a09cc48bfbddcbf056b946c8a80438f0',
        u'feature_groups': [u'mirantis'],
        u'release': u'6.1',
        u'fuelmain_sha': u'320b5f46fc1b2798f9e86ed7df51d3bda1686c10',
        u'fuellib_sha': u'345a98b34dd0cd450a45d405ac47a6a9fa48b6d8',
        }}},
    u'fuellib_sha': u'345a98b34dd0cd450a45d405ac47a6a9fa48b6d8',
    }

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.